Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2199253002:
[inspector] include additional outputs from protocol handler generator. (Closed)
Description[inspector] include additional outputs from protocol handler generator.
The protocol handler generator generates these files into a default location if
not specified by flag as output. We should account for these files and
explicitly set its output location.
R=machenbach@chromium.org
Committed: https://crrev.com/ac1d077db39dcabb74e36ad5d4bc7ea9fad96ed9
Committed: https://crrev.com/c7e9a8dc60735aa7581a6acce956cf9373528c11
Cr-Original-Commit-Position: refs/heads/master@{#38268}
Cr-Commit-Position: refs/heads/master@{#38273}
Patch Set 1 #
Total comments: 2
Patch Set 2 : also update to new js_protocol.json #
Messages
Total messages: 26 (14 generated)
lgtm https://codereview.chromium.org/2199253002/diff/1/src/inspector/BUILD.gn File src/inspector/BUILD.gn (right): https://codereview.chromium.org/2199253002/diff/1/src/inspector/BUILD.gn#newc... src/inspector/BUILD.gn:49: "inspector/public", This / is ok also on windows? Guess so as the gyp version already had some slashes...
https://codereview.chromium.org/2199253002/diff/1/src/inspector/BUILD.gn File src/inspector/BUILD.gn (right): https://codereview.chromium.org/2199253002/diff/1/src/inspector/BUILD.gn#newc... src/inspector/BUILD.gn:49: "inspector/public", On 2016/08/02 10:45:35, Michael Achenbach (slow) wrote: > This / is ok also on windows? Guess so as the gyp version already had some > slashes... This string is used to fill the template when generating the protocol handler files. It will end up as part of #include paths. So I think this is fine.
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
faith4roy16@gmail.com changed reviewers: + faith4roy16@gmail.com
lgtm
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from faith4roy16@gmail.com, machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/2199253002/#ps20001 (title: "also update to new js_protocol.json")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [inspector] include additional outputs from protocol handler generator. The protocol handler generator generates these files into a default location if not specified by flag as output. We should account for these files and explicitly set its output location. R=machenbach@chromium.org ========== to ========== [inspector] include additional outputs from protocol handler generator. The protocol handler generator generates these files into a default location if not specified by flag as output. We should account for these files and explicitly set its output location. R=machenbach@chromium.org Committed: https://crrev.com/ac1d077db39dcabb74e36ad5d4bc7ea9fad96ed9 Cr-Commit-Position: refs/heads/master@{#38268} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ac1d077db39dcabb74e36ad5d4bc7ea9fad96ed9 Cr-Commit-Position: refs/heads/master@{#38268}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2206573004/ by yangguo@chromium.org. The reason for reverting is: Compile warnings: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang/builds....
Message was sent while issue was closed.
Description was changed from ========== [inspector] include additional outputs from protocol handler generator. The protocol handler generator generates these files into a default location if not specified by flag as output. We should account for these files and explicitly set its output location. R=machenbach@chromium.org Committed: https://crrev.com/ac1d077db39dcabb74e36ad5d4bc7ea9fad96ed9 Cr-Commit-Position: refs/heads/master@{#38268} ========== to ========== [inspector] include additional outputs from protocol handler generator. The protocol handler generator generates these files into a default location if not specified by flag as output. We should account for these files and explicitly set its output location. R=machenbach@chromium.org Committed: https://crrev.com/ac1d077db39dcabb74e36ad5d4bc7ea9fad96ed9 Cr-Commit-Position: refs/heads/master@{#38268} ==========
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by yangguo@chromium.org
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [inspector] include additional outputs from protocol handler generator. The protocol handler generator generates these files into a default location if not specified by flag as output. We should account for these files and explicitly set its output location. R=machenbach@chromium.org Committed: https://crrev.com/ac1d077db39dcabb74e36ad5d4bc7ea9fad96ed9 Cr-Commit-Position: refs/heads/master@{#38268} ========== to ========== [inspector] include additional outputs from protocol handler generator. The protocol handler generator generates these files into a default location if not specified by flag as output. We should account for these files and explicitly set its output location. R=machenbach@chromium.org Committed: https://crrev.com/ac1d077db39dcabb74e36ad5d4bc7ea9fad96ed9 Cr-Commit-Position: refs/heads/master@{#38268} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [inspector] include additional outputs from protocol handler generator. The protocol handler generator generates these files into a default location if not specified by flag as output. We should account for these files and explicitly set its output location. R=machenbach@chromium.org Committed: https://crrev.com/ac1d077db39dcabb74e36ad5d4bc7ea9fad96ed9 Cr-Commit-Position: refs/heads/master@{#38268} ========== to ========== [inspector] include additional outputs from protocol handler generator. The protocol handler generator generates these files into a default location if not specified by flag as output. We should account for these files and explicitly set its output location. R=machenbach@chromium.org Committed: https://crrev.com/ac1d077db39dcabb74e36ad5d4bc7ea9fad96ed9 Committed: https://crrev.com/c7e9a8dc60735aa7581a6acce956cf9373528c11 Cr-Original-Commit-Position: refs/heads/master@{#38268} Cr-Commit-Position: refs/heads/master@{#38273} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c7e9a8dc60735aa7581a6acce956cf9373528c11 Cr-Commit-Position: refs/heads/master@{#38273} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
