Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Unified Diff: chrome/browser/push_messaging/push_messaging_browsertest.cc

Issue 2199213003: Use NotAllowedError instead of PermissionDeniedError for the Push API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix the browser tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/child/push_messaging/push_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/push_messaging/push_messaging_browsertest.cc
diff --git a/chrome/browser/push_messaging/push_messaging_browsertest.cc b/chrome/browser/push_messaging/push_messaging_browsertest.cc
index cd5b4409920819a6829f7bd93962cce33e2499ba..4202175382ce6b1634dd45a993eaa79c7a0998ec 100644
--- a/chrome/browser/push_messaging/push_messaging_browsertest.cc
+++ b/chrome/browser/push_messaging/push_messaging_browsertest.cc
@@ -420,7 +420,7 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
RequestAndDenyPermission();
ASSERT_TRUE(RunScript("documentSubscribePush()", &script_result));
- EXPECT_EQ("PermissionDeniedError - Registration failed - permission denied",
+ EXPECT_EQ("NotAllowedError - Registration failed - permission denied",
script_result);
}
@@ -470,7 +470,7 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTestEmptySubscriptionOptions,
RequestAndAcceptPermission();
ASSERT_TRUE(RunScript("documentSubscribePush()", &script_result));
- EXPECT_EQ("PermissionDeniedError - Registration failed - permission denied",
+ EXPECT_EQ("NotAllowedError - Registration failed - permission denied",
script_result);
}
@@ -1086,7 +1086,7 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, PermissionStateSaysDenied) {
RequestAndDenyPermission();
ASSERT_TRUE(RunScript("documentSubscribePush()", &script_result));
- EXPECT_EQ("PermissionDeniedError - Registration failed - permission denied",
+ EXPECT_EQ("NotAllowedError - Registration failed - permission denied",
script_result);
ASSERT_TRUE(RunScript("permissionState()", &script_result));
« no previous file with comments | « no previous file | content/child/push_messaging/push_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698