Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 2199093002: Optimize webgl texImage2D from YUV video textures. (Closed)

Created:
4 years, 4 months ago by jbauman
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Optimize webgl texImage2D from YUV video textures. The current path does a conversion from YUV to an RGBA SkImage, then paints that to another Skia canvas and does a CopyTexImageCHROMIUM to the WebGL texture. We can optimize this by removing the paint to the canvas and doing a copy directly from the SkImage to the WebGL texture. BUG=625900 Review-Url: https://codereview.chromium.org/2127053004 Cr-Commit-Position: refs/heads/master@{#406735} (cherry picked from commit 581d041c9971bb533e2cbd5c57014ee026fb50e6) Committed: https://chromium.googlesource.com/chromium/src/+/9453c3f083a2f9d777412cf67cbd5feacfc3b87d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -40 lines) Patch
M content/renderer/media/webmediaplayer_ms.cc View 1 chunk +12 lines, -7 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.h View 2 chunks +21 lines, -0 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 3 chunks +103 lines, -27 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jbauman
4 years, 4 months ago (2016-08-01 22:21:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9453c3f083a2f9d777412cf67cbd5feacfc3b87d.

Powered by Google App Engine
This is Rietveld 408576698