Mojo C++ bindings: inline struct data view field getters.

Mojo C++ bindings: inline struct data view field getters.

This significantly improves deserialization performance of cc_serialization_perftest by about 25~30%.

BUG=624459
NO_DEPENDENCY_CHECKS=true

Committed: https://crrev.com/1b78a8928c31188e2ca1e24d031031fd619dba7b
Cr-Commit-Position: refs/heads/master@{#409212}

[yzshen1, 2016-08-01 21:07:20]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 21:07:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-08-01 21:11:48]

Average numbers from three runs of cc_perftests:

StructTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_100000_100000': base: 35.333333333333336 new: 42.0
imprv: 1.1886792452830188
StructTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_1_100000': base: 74.0 new: 95.33333333333333 imprv:
1.2882882882882882
StructTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_1_4000': base: 2023.6666666666667 new: 2784.0 imprv:
1.3757206391039367
StructTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyQuads_4000_4000': base: 1016.0 new: 1286.6666666666667 imprv:
1.2664041994750657
StructTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyRenderPasses_10000_100': base: 33.0 new: 41.333333333333336
imprv: 1.2525252525252526
StructTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyRenderPasses_10_500': base: 874.6666666666666 new:
1093.3333333333333 imprv: 1.25
StructTraits deserialization: num runs in 2 seconds:
DelegatedFrame_ManyRenderPasses_5_100': base: 9483.0 new: 12185.333333333334
imprv: 1.2849660796513058

|base|: without CL
|new|: with CL
|imprv|: |new|/|base|

[yzshen1, 2016-08-01 21:15:41]

Description was changed from

==========
Mojo C++ bindings: inline struct data view field getters.

This significantly improve deserialization performance.

BUG=624459
==========

to

==========
Mojo C++ bindings: inline struct data view field getters.

This significantly improves deserialization performance of
cc_serialization_perftest by about 25~30%.

BUG=624459
==========

[yzshen1, 2016-08-01 21:15:41]

yzshen@chromium.org changed reviewers:
+ rockot@chromium.org

[yzshen1, 2016-08-01 21:18:59]

Hi, Ken.

Would you please take a look? thanks!

[Ken Rockot(use gerrit already), 2016-08-01 22:07:16]

lgtm

[yzshen1, 2016-08-01 22:13:23]

The CQ bit was unchecked by yzshen@chromium.org

[yzshen1, 2016-08-01 22:13:24]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-08-01 22:13:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 22:13:44]

This CL has an open dependency (Issue 2196873002 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[yzshen1, 2016-08-01 22:14:58]

Description was changed from

==========
Mojo C++ bindings: inline struct data view field getters.

This significantly improves deserialization performance of
cc_serialization_perftest by about 25~30%.

BUG=624459
==========

to

==========
Mojo C++ bindings: inline struct data view field getters.

This significantly improves deserialization performance of
cc_serialization_perftest by about 25~30%.

BUG=624459
NO_DEPENDENCY_CHECKS=true
==========

[yzshen1, 2016-08-01 22:15:05]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-08-01 22:15:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 22:21:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 22:21:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yzshen1, 2016-08-02 15:46:25]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-08-02 15:46:25]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2199043002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-08-02 15:46:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 17:10:18]

Description was changed from

==========
Mojo C++ bindings: inline struct data view field getters.

This significantly improves deserialization performance of
cc_serialization_perftest by about 25~30%.

BUG=624459
NO_DEPENDENCY_CHECKS=true
==========

to

==========
Mojo C++ bindings: inline struct data view field getters.

This significantly improves deserialization performance of
cc_serialization_perftest by about 25~30%.

BUG=624459
NO_DEPENDENCY_CHECKS=true
==========

[commit-bot: I haz the power, 2016-08-02 17:10:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-02 17:11:46]

Description was changed from

==========
Mojo C++ bindings: inline struct data view field getters.

This significantly improves deserialization performance of
cc_serialization_perftest by about 25~30%.

BUG=624459
NO_DEPENDENCY_CHECKS=true
==========

to

==========
Mojo C++ bindings: inline struct data view field getters.

This significantly improves deserialization performance of
cc_serialization_perftest by about 25~30%.

BUG=624459
NO_DEPENDENCY_CHECKS=true

Committed: https://crrev.com/1b78a8928c31188e2ca1e24d031031fd619dba7b
Cr-Commit-Position: refs/heads/master@{#409212}
==========

[commit-bot: I haz the power, 2016-08-02 17:11:48]

Patchset 2 (id:??) landed as
https://crrev.com/1b78a8928c31188e2ca1e24d031031fd619dba7b
Cr-Commit-Position: refs/heads/master@{#409212}