Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2199023002:
mash: Paritally migrate ShelfLayoutManagerTest to ash common types. (Closed)
|
Created:
4 years, 4 months ago by msw Modified:
4 years, 4 months ago Reviewers:
James Cook CC:
chromium-reviews, kalyank, sadrul Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmash: Paritally migrate ShelfLayoutManagerTest to ash common types.
Use CreateTestWidget where possible.
Use AshTestBase::GetEventGenerator() throughout.
Use display::Screen::GetPrimaryDisplay().
Try to re-enable some tests.
Try to avoid SupportsHostWindowResize early returns.
BUG=631215
TEST=Automated
R=jamescook@chromium.org
Committed: https://crrev.com/298130395887de9cb3367d735f1977fc17762e1c
Cr-Commit-Position: refs/heads/master@{#409276}
Patch Set 1 #Patch Set 2 : Minor cleanup. #Patch Set 3 : Add Windows workaround and comment for StatusAreaHitBoxCoversEdge. #
Total comments: 6
Patch Set 4 : Address StatusAreaHitBoxCoversEdge comments. #
Total comments: 4
Patch Set 5 : Address StatusAreaHitBoxCoversEdge comments. #Messages
Total messages: 23 (15 generated)
The CQ bit was checked by msw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Description was changed from ========== mash: Paritally migrate ShelfLayoutManagerTest to ash common types. Use CreateTestWidget where possible. Use AshTestBase::GetEventGenerator() throughout. Use display::Screen::GetPrimaryDisplay(). Try to re-enable some tests. Try to avoid SupportsHostWindowResize early returns. BUG=631215 TEST=Automated R=jamescook@chromium.org ========== to ========== mash: Paritally migrate ShelfLayoutManagerTest to ash common types. Use CreateTestWidget where possible. Use AshTestBase::GetEventGenerator() throughout. Use display::Screen::GetPrimaryDisplay(). Try to re-enable some tests. Try to avoid SupportsHostWindowResize early returns. BUG=631215 TEST=Automated R=jamescook@chromium.org ==========
Hey James, please take a look; thanks!
The CQ bit was checked by msw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Nice cleanup! Just a couple things. https://codereview.chromium.org/2199023002/diff/40001/ash/shelf/shelf_layout_... File ash/shelf/shelf_layout_manager_unittest.cc (left): https://codereview.chromium.org/2199023002/diff/40001/ash/shelf/shelf_layout_... ash/shelf/shelf_layout_manager_unittest.cc:1863: if (!SupportsHostWindowResize()) It's great you cleaned up unnecessary stuff like this. https://codereview.chromium.org/2199023002/diff/40001/ash/shelf/shelf_layout_... File ash/shelf/shelf_layout_manager_unittest.cc (right): https://codereview.chromium.org/2199023002/diff/40001/ash/shelf/shelf_layout_... ash/shelf/shelf_layout_manager_unittest.cc:1958: #endif If possible I would just #if !defined(OS_WIN) the EXPECT calls below, rather than adding an extra move on Windows. I got confused when I first read this. Same below. https://codereview.chromium.org/2199023002/diff/40001/ash/shelf/shelf_layout_... ash/shelf/shelf_layout_manager_unittest.cc:1980: generator.MoveMouseTo(inset_display_bounds.bottom_left()); Doesn't this check 1, 398 instead of 0, 399? (We've had Fitts' Law violation bugs in the past, which is why this tests the corners.)
Please take another look; thanks! https://codereview.chromium.org/2199023002/diff/40001/ash/shelf/shelf_layout_... File ash/shelf/shelf_layout_manager_unittest.cc (left): https://codereview.chromium.org/2199023002/diff/40001/ash/shelf/shelf_layout_... ash/shelf/shelf_layout_manager_unittest.cc:1863: if (!SupportsHostWindowResize()) On 2016/08/02 16:34:18, James Cook wrote: > It's great you cleaned up unnecessary stuff like this. Acknowledged. https://codereview.chromium.org/2199023002/diff/40001/ash/shelf/shelf_layout_... File ash/shelf/shelf_layout_manager_unittest.cc (right): https://codereview.chromium.org/2199023002/diff/40001/ash/shelf/shelf_layout_... ash/shelf/shelf_layout_manager_unittest.cc:1958: #endif On 2016/08/02 16:34:18, James Cook wrote: > If possible I would just #if !defined(OS_WIN) the EXPECT calls below, rather > than adding an extra move on Windows. I got confused when I first read this. > Same below. Done. https://codereview.chromium.org/2199023002/diff/40001/ash/shelf/shelf_layout_... ash/shelf/shelf_layout_manager_unittest.cc:1980: generator.MoveMouseTo(inset_display_bounds.bottom_left()); On 2016/08/02 16:34:18, James Cook wrote: > Doesn't this check 1, 398 instead of 0, 399? (We've had Fitts' Law violation > bugs in the past, which is why this tests the corners.) Done. Thanks for catching that!
The CQ bit was checked by msw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM with nit. Nice patch! https://codereview.chromium.org/2199023002/diff/60001/ash/shelf/shelf_layout_... File ash/shelf/shelf_layout_manager_unittest.cc (right): https://codereview.chromium.org/2199023002/diff/60001/ash/shelf/shelf_layout_... ash/shelf/shelf_layout_manager_unittest.cc:1955: generator.ClickLeftButton(); nit: put this inside the #if so Windows doesn't get 2 clicks https://codereview.chromium.org/2199023002/diff/60001/ash/shelf/shelf_layout_... ash/shelf/shelf_layout_manager_unittest.cc:1967: generator.ClickLeftButton(); ditto
https://codereview.chromium.org/2199023002/diff/60001/ash/shelf/shelf_layout_... File ash/shelf/shelf_layout_manager_unittest.cc (right): https://codereview.chromium.org/2199023002/diff/60001/ash/shelf/shelf_layout_... ash/shelf/shelf_layout_manager_unittest.cc:1955: generator.ClickLeftButton(); On 2016/08/02 18:17:37, James Cook wrote: > nit: put this inside the #if so Windows doesn't get 2 clicks Done. https://codereview.chromium.org/2199023002/diff/60001/ash/shelf/shelf_layout_... ash/shelf/shelf_layout_manager_unittest.cc:1967: generator.ClickLeftButton(); On 2016/08/02 18:17:38, James Cook wrote: > ditto Done.
The CQ bit was checked by msw@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jamescook@chromium.org Link to the patchset: https://codereview.chromium.org/2199023002/#ps80001 (title: "Address StatusAreaHitBoxCoversEdge comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== mash: Paritally migrate ShelfLayoutManagerTest to ash common types. Use CreateTestWidget where possible. Use AshTestBase::GetEventGenerator() throughout. Use display::Screen::GetPrimaryDisplay(). Try to re-enable some tests. Try to avoid SupportsHostWindowResize early returns. BUG=631215 TEST=Automated R=jamescook@chromium.org ========== to ========== mash: Paritally migrate ShelfLayoutManagerTest to ash common types. Use CreateTestWidget where possible. Use AshTestBase::GetEventGenerator() throughout. Use display::Screen::GetPrimaryDisplay(). Try to re-enable some tests. Try to avoid SupportsHostWindowResize early returns. BUG=631215 TEST=Automated R=jamescook@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== mash: Paritally migrate ShelfLayoutManagerTest to ash common types. Use CreateTestWidget where possible. Use AshTestBase::GetEventGenerator() throughout. Use display::Screen::GetPrimaryDisplay(). Try to re-enable some tests. Try to avoid SupportsHostWindowResize early returns. BUG=631215 TEST=Automated R=jamescook@chromium.org ========== to ========== mash: Paritally migrate ShelfLayoutManagerTest to ash common types. Use CreateTestWidget where possible. Use AshTestBase::GetEventGenerator() throughout. Use display::Screen::GetPrimaryDisplay(). Try to re-enable some tests. Try to avoid SupportsHostWindowResize early returns. BUG=631215 TEST=Automated R=jamescook@chromium.org Committed: https://crrev.com/298130395887de9cb3367d735f1977fc17762e1c Cr-Commit-Position: refs/heads/master@{#409276} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/298130395887de9cb3367d735f1977fc17762e1c Cr-Commit-Position: refs/heads/master@{#409276} |
