Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2199003003: Deprecate CpuProfileNode::GetCallUid (Closed)

Created:
4 years, 4 months ago by alph
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Deprecate CpuProfileNode::GetCallUid The client can use scriptId + lineNumber + columnNumber to uniquelly identify the call site. Committed: https://crrev.com/d25e45df73545e6893a9081f38be77b18ffb1485 Cr-Commit-Position: refs/heads/master@{#38236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M include/v8-profiler.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
alph
4 years, 4 months ago (2016-08-02 09:11:50 UTC) #2
Yang
On 2016/08/02 09:11:50, alph_slow wrote: lgtm.
4 years, 4 months ago (2016-08-02 09:13:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199003003/1
4 years, 4 months ago (2016-08-02 09:15:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 09:41:35 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 09:45:08 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d25e45df73545e6893a9081f38be77b18ffb1485
Cr-Commit-Position: refs/heads/master@{#38236}

Powered by Google App Engine
This is Rietveld 408576698