Revert of Use only toolbar to transition from fakebox to real omnibox.

Revert of Use only toolbar to transition from fakebox to real omnibox. (patchset #11 id:200001 of https://codereview.chromium.org/2134663002/ )

Reason for revert:
Suspect for http://crbug.com/633321, will re-land if not.

Original issue's description:
> Use only toolbar to transition from fakebox to real omnibox.
>
> Previously, we would fade out the fakebox and fade in the real omnibox during
> the scroll transition, which created discrepancies. With this change, the
> toolbar omnibox does the full transition. The search box on the NTP is still
> kept, both to get the starting point of the transition, and for the tablet
> toolbar, where the omnibox stays at the top, so there are two boxes.
>
> Because the two boxes now have to match, their dimensions and padding are
> slightly updated. The height is 56dp, and the padding on the sides is 12dp.
>
> Also, in the focused state the omnibox now has 1dp bleed at the sides,
> which moves the rounded corners out of view.
>
> The remaining changes are not user-visible:
> * Opacity of the fakebox is now driven by the toolbar. This lets us centralize
>   the logic (the toolbar can decide its own opacity and the opacity of the
>   fakebox) and use different behavior on tablets, where the fakebox will simply
>   fade out as before.
> * Rename variables to (hopefully) make them more consistent / self-explanatory.
> * |mLocationBarBackgroundBounds| (formerly |mUrlViewportBounds|) more accurately
>   reflects the visible omnibox bounds in the absence of the NTP / when the NTP
>   is scrolled so that the omnibox is at the top. To do that, we no longer
>   include the Y translation we apply to position it where the fakebox is (it's
>   instead applied to the |mLocationBarBackgroundNtpOffset|), and we always use
>   an expansion value of 1 if the current tab is an NTP.
> * Remove the |inset_textbox| drawable -- it was the same as |textbox|, but with
>   a margin added at the top and bottom (but *not* left or right). Since we
>   calculate the omnibox bounds manually anyway, this allows us to account for
>   the omnibox padding in the same way in either dimension.
> * Remove the |isInTabSwitcherMode| parameter from some methods in favor of using
>   the member variable.
>
> BUG=605054, 625108, 618955, 616728, 612520
>
> Committed: https://crrev.com/7a676cfc5291809bf2a95fd16ba1d57907f7961a
> Cr-Commit-Position: refs/heads/master@{#408885}

TBR=peconn@chromium.org,mcwilliams@chromium.org,mdjones@chromium.org,tedchoc@chromium.org,bauerb@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=605054, 625108, 618955, 616728, 612520
Committed: https://crrev.com/ed720fdd749d46e0934267bd8f935bbeb1ec0991
Cr-Commit-Position: refs/heads/master@{#409045}

[gab, 2016-08-01 19:50:18]

The CQ bit was checked by gab@chromium.org

[gab, 2016-08-01 19:50:18]

Created Revert of Use only toolbar to transition from fakebox to real omnibox.

[commit-bot: I haz the power, 2016-08-01 19:50:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 20:36:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-01 20:42:03]

Description was changed from

==========
Revert of Use only toolbar to transition from fakebox to real omnibox. (patchset
#11 id:200001 of https://codereview.chromium.org/2134663002/ )

Reason for revert:
Suspect for http://crbug.com/633321, will re-land if not.

Original issue's description:
> Use only toolbar to transition from fakebox to real omnibox.
> 
> Previously, we would fade out the fakebox and fade in the real omnibox during
> the scroll transition, which created discrepancies. With this change, the
> toolbar omnibox does the full transition. The search box on the NTP is still
> kept, both to get the starting point of the transition, and for the tablet
> toolbar, where the omnibox stays at the top, so there are two boxes.
> 
> Because the two boxes now have to match, their dimensions and padding are
> slightly updated. The height is 56dp, and the padding on the sides is 12dp.
> 
> Also, in the focused state the omnibox now has 1dp bleed at the sides,
> which moves the rounded corners out of view.
> 
> The remaining changes are not user-visible:
> * Opacity of the fakebox is now driven by the toolbar. This lets us centralize
>   the logic (the toolbar can decide its own opacity and the opacity of the
>   fakebox) and use different behavior on tablets, where the fakebox will
simply
>   fade out as before.
> * Rename variables to (hopefully) make them more consistent /
self-explanatory.
> * |mLocationBarBackgroundBounds| (formerly |mUrlViewportBounds|) more
accurately
>   reflects the visible omnibox bounds in the absence of the NTP / when the NTP
>   is scrolled so that the omnibox is at the top. To do that, we no longer
>   include the Y translation we apply to position it where the fakebox is (it's
>   instead applied to the |mLocationBarBackgroundNtpOffset|), and we always use
>   an expansion value of 1 if the current tab is an NTP.
> * Remove the |inset_textbox| drawable -- it was the same as |textbox|, but
with
>   a margin added at the top and bottom (but *not* left or right). Since we
>   calculate the omnibox bounds manually anyway, this allows us to account for
>   the omnibox padding in the same way in either dimension.
> * Remove the |isInTabSwitcherMode| parameter from some methods in favor of
using
>   the member variable.
> 
> BUG=605054,625108,618955,616728,612520
> 
> Committed: https://crrev.com/7a676cfc5291809bf2a95fd16ba1d57907f7961a
> Cr-Commit-Position: refs/heads/master@{#408885}

TBR=peconn@chromium.org,mcwilliams@chromium.org,mdjones@chromium.org,tedchoc@...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=605054,625108,618955,616728,612520
==========

to

==========
Revert of Use only toolbar to transition from fakebox to real omnibox. (patchset
#11 id:200001 of https://codereview.chromium.org/2134663002/ )

Reason for revert:
Suspect for http://crbug.com/633321, will re-land if not.

Original issue's description:
> Use only toolbar to transition from fakebox to real omnibox.
>
> Previously, we would fade out the fakebox and fade in the real omnibox during
> the scroll transition, which created discrepancies. With this change, the
> toolbar omnibox does the full transition. The search box on the NTP is still
> kept, both to get the starting point of the transition, and for the tablet
> toolbar, where the omnibox stays at the top, so there are two boxes.
>
> Because the two boxes now have to match, their dimensions and padding are
> slightly updated. The height is 56dp, and the padding on the sides is 12dp.
>
> Also, in the focused state the omnibox now has 1dp bleed at the sides,
> which moves the rounded corners out of view.
>
> The remaining changes are not user-visible:
> * Opacity of the fakebox is now driven by the toolbar. This lets us centralize
>   the logic (the toolbar can decide its own opacity and the opacity of the
>   fakebox) and use different behavior on tablets, where the fakebox will
simply
>   fade out as before.
> * Rename variables to (hopefully) make them more consistent /
self-explanatory.
> * |mLocationBarBackgroundBounds| (formerly |mUrlViewportBounds|) more
accurately
>   reflects the visible omnibox bounds in the absence of the NTP / when the NTP
>   is scrolled so that the omnibox is at the top. To do that, we no longer
>   include the Y translation we apply to position it where the fakebox is (it's
>   instead applied to the |mLocationBarBackgroundNtpOffset|), and we always use
>   an expansion value of 1 if the current tab is an NTP.
> * Remove the |inset_textbox| drawable -- it was the same as |textbox|, but
with
>   a margin added at the top and bottom (but *not* left or right). Since we
>   calculate the omnibox bounds manually anyway, this allows us to account for
>   the omnibox padding in the same way in either dimension.
> * Remove the |isInTabSwitcherMode| parameter from some methods in favor of
using
>   the member variable.
>
> BUG=605054,625108,618955,616728,612520
>
> Committed: https://crrev.com/7a676cfc5291809bf2a95fd16ba1d57907f7961a
> Cr-Commit-Position: refs/heads/master@{#408885}

TBR=peconn@chromium.org,mcwilliams@chromium.org,mdjones@chromium.org,tedchoc@...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=605054,625108,618955,616728,612520

Committed: https://crrev.com/ed720fdd749d46e0934267bd8f935bbeb1ec0991
Cr-Commit-Position: refs/heads/master@{#409045}
==========

[commit-bot: I haz the power, 2016-08-01 20:42:04]

Patchset 1 (id:??) landed as
https://crrev.com/ed720fdd749d46e0934267bd8f935bbeb1ec0991
Cr-Commit-Position: refs/heads/master@{#409045}

[Mathieu, 2016-08-01 21:40:27]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2204613002/ by mathp@chromium.org.

The reason for reverting is: Was not the culprit for webkit_unit_tests failing..
relanding.