Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: third_party/WebKit/Source/platform/exported/WebMixedContent.cpp

Issue 2198933003: Prevent mixed content iframes on back/forward. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/exported/WebMixedContent.cpp
diff --git a/third_party/WebKit/Source/platform/exported/WebMixedContent.cpp b/third_party/WebKit/Source/platform/exported/WebMixedContent.cpp
index 1aac75dd75dadeccf7bad218f692e148d9cef61b..cd11497a3f4ab4acdde1a7822b2ed36800f0afa4 100644
--- a/third_party/WebKit/Source/platform/exported/WebMixedContent.cpp
+++ b/third_party/WebKit/Source/platform/exported/WebMixedContent.cpp
@@ -61,6 +61,7 @@ WebMixedContent::ContextType WebMixedContent::contextTypeFromRequestContext(WebU
case WebURLRequest::RequestContextIframe:
case WebURLRequest::RequestContextImageSet:
case WebURLRequest::RequestContextImport:
+ case WebURLRequest::RequestContextInternal:
Charlie Reis 2016/08/01 23:39:16 Is this safe?
Mike West 2016/08/02 07:41:51 I wouldn't have thought so, though it surprises me
case WebURLRequest::RequestContextLocation:
case WebURLRequest::RequestContextManifest:
case WebURLRequest::RequestContextObject:
@@ -78,7 +79,6 @@ WebMixedContent::ContextType WebMixedContent::contextTypeFromRequestContext(WebU
// FIXME: Contexts that we should block, but don't currently. https://crbug.com/388650
case WebURLRequest::RequestContextDownload:
- case WebURLRequest::RequestContextInternal:
case WebURLRequest::RequestContextPrefetch:
return ContextType::ShouldBeBlockable;

Powered by Google App Engine
This is Rietveld 408576698