Add parent pointer to NavigationEntryImpl::TreeNode.

Add parent pointer to NavigationEntryImpl::TreeNode.

Currently the tree of FrameNavigationEntries in NavigationEntryImpl does
not have any way for traversing from an arbitrary node in the tree up
to its parent. This is useful when comparing the expected chain of
ancestors, which is needed to fix issue 628677.

BUG=628677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/be89fac7f6e0117dd8f12ae844a34565a9d25927
Cr-Commit-Position: refs/heads/master@{#409013}

[nasko, 2016-08-01 17:06:44]

Description was changed from

==========
Add parent pointer to NavigationEntryImpl::TreeNode.

Currently the tree of FrameNavigationEntries in NavigationEntryImpl does
not have any way for traversing from an arbitrary node in the tree up
to its parent. This is useful when comparing the expected chain of
ancestors, which is needed to fix issue 628677.

BUG=628677
==========

to

==========
Add parent pointer to NavigationEntryImpl::TreeNode.

Currently the tree of FrameNavigationEntries in NavigationEntryImpl does
not have any way for traversing from an arbitrary node in the tree up
to its parent. This is useful when comparing the expected chain of
ancestors, which is needed to fix issue 628677.

BUG=628677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[nasko, 2016-08-01 17:38:38]

nasko@chromium.org changed reviewers:
+ creis@chromium.org

[nasko, 2016-08-01 17:38:39]

Hey Charlie,
This CL is a small refactor to add parent pointer to the NavEntry::TreeNode
struct. I think it will make it easier to implement walking the ancestor chain
and on its own it makes MatchesFrame a bit nicer :). Can you review it for me?
Thanks in advance!
Nasko

[nasko, 2016-08-01 17:38:58]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 17:39:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2016-08-01 18:13:59]

LGTM!  I agree this makes things nicer, and I'm happy to get rid of
is_root_tree_node from MatchesFrame.

[nasko, 2016-08-01 18:37:28]

The CQ bit was unchecked by nasko@chromium.org

[nasko, 2016-08-01 18:37:34]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2016-08-01 18:37:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 19:00:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-01 19:06:19]

Description was changed from

==========
Add parent pointer to NavigationEntryImpl::TreeNode.

Currently the tree of FrameNavigationEntries in NavigationEntryImpl does
not have any way for traversing from an arbitrary node in the tree up
to its parent. This is useful when comparing the expected chain of
ancestors, which is needed to fix issue 628677.

BUG=628677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add parent pointer to NavigationEntryImpl::TreeNode.

Currently the tree of FrameNavigationEntries in NavigationEntryImpl does
not have any way for traversing from an arbitrary node in the tree up
to its parent. This is useful when comparing the expected chain of
ancestors, which is needed to fix issue 628677.

BUG=628677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/be89fac7f6e0117dd8f12ae844a34565a9d25927
Cr-Commit-Position: refs/heads/master@{#409013}
==========

[commit-bot: I haz the power, 2016-08-01 19:06:20]

Patchset 2 (id:??) landed as
https://crrev.com/be89fac7f6e0117dd8f12ae844a34565a9d25927
Cr-Commit-Position: refs/heads/master@{#409013}