Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2198853002: Draw main frame custom scrollbars in root layer scrolling mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: modified as per review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 2621 matching lines...) Expand 10 before | Expand all | Expand 10 after
2632 if (GraphicsLayer* layerForHorizontalScrollbar = view.compositor()->layerFor HorizontalScrollbar()) { 2632 if (GraphicsLayer* layerForHorizontalScrollbar = view.compositor()->layerFor HorizontalScrollbar()) {
2633 synchronizedPaintRecursively(layerForHorizontalScrollbar); 2633 synchronizedPaintRecursively(layerForHorizontalScrollbar);
2634 } 2634 }
2635 if (GraphicsLayer* layerForVerticalScrollbar = view.compositor()->layerForVe rticalScrollbar()) { 2635 if (GraphicsLayer* layerForVerticalScrollbar = view.compositor()->layerForVe rticalScrollbar()) {
2636 synchronizedPaintRecursively(layerForVerticalScrollbar); 2636 synchronizedPaintRecursively(layerForVerticalScrollbar);
2637 } 2637 }
2638 if (GraphicsLayer* layerForScrollCorner = view.compositor()->layerForScrollC orner()) { 2638 if (GraphicsLayer* layerForScrollCorner = view.compositor()->layerForScrollC orner()) {
2639 synchronizedPaintRecursively(layerForScrollCorner); 2639 synchronizedPaintRecursively(layerForScrollCorner);
2640 } 2640 }
2641 2641
2642 if (!layoutViewItem().isNull() && layoutViewItem().layer()->hasCompositedLay erMapping()) {
bokan 2016/08/11 14:34:29 IMO, instead of doing this, we should fix FrameVie
MuVen 2016/08/11 14:45:57 That's a great idea to fix in layerForHorizontalSc
2643 CompositedLayerMapping* compositedLayerMapping = layoutViewItem().layer( )->compositedLayerMapping();
2644 if (GraphicsLayer* layerForHorizontalScrollbar = compositedLayerMapping- >layerForHorizontalScrollbar()) {
2645 synchronizedPaintRecursively(layerForHorizontalScrollbar);
2646 }
2647 if (GraphicsLayer* layerForVerticalScrollbar = compositedLayerMapping->l ayerForVerticalScrollbar()) {
2648 synchronizedPaintRecursively(layerForVerticalScrollbar);
2649 }
2650 if (GraphicsLayer* layerForScrollCorner = compositedLayerMapping->layerF orScrollCorner()) {
2651 synchronizedPaintRecursively(layerForScrollCorner);
2652 }
2653 }
2654
2642 forAllNonThrottledFrameViews([](FrameView& frameView) { 2655 forAllNonThrottledFrameViews([](FrameView& frameView) {
2643 frameView.lifecycle().advanceTo(DocumentLifecycle::PaintClean); 2656 frameView.lifecycle().advanceTo(DocumentLifecycle::PaintClean);
2644 LayoutViewItem layoutViewItem = frameView.layoutViewItem(); 2657 LayoutViewItem layoutViewItem = frameView.layoutViewItem();
2645 if (!layoutViewItem.isNull()) 2658 if (!layoutViewItem.isNull())
2646 layoutViewItem.layer()->clearNeedsRepaintRecursively(); 2659 layoutViewItem.layer()->clearNeedsRepaintRecursively();
2647 }); 2660 });
2648 } 2661 }
2649 2662
2650 void FrameView::synchronizedPaintRecursively(GraphicsLayer* graphicsLayer) 2663 void FrameView::synchronizedPaintRecursively(GraphicsLayer* graphicsLayer)
2651 { 2664 {
(...skipping 1632 matching lines...) Expand 10 before | Expand all | Expand 10 after
4284 } 4297 }
4285 4298
4286 bool FrameView::canThrottleRendering() const 4299 bool FrameView::canThrottleRendering() const
4287 { 4300 {
4288 if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled()) 4301 if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled())
4289 return false; 4302 return false;
4290 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling); 4303 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling);
4291 } 4304 }
4292 4305
4293 } // namespace blink 4306 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698