Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2198733003: Hide some member functions of SpellChecker as private (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide some member functions of SpellChecker as private This patch hides the following member functions of SpellChecker as private because they are only used by SpellChecker itself: bool markMisspellings(const VisibleSelection&); void markBadGrammar(const VisibleSelection&); bool markMisspellingsOrBadGrammar(const VisibleSelection&, bool checkSpelling); void markMisspellingsAndBadGrammar(const VisibleSelection& spellingSelection, bool markGrammar, const VisibleSelection& grammarSelection); void spellCheckOldSelection(const VisibleSelection& oldSelection, const VisibleSelection& newAdjacentWords); This patch is a preparation for cleaning up grammar checking code from SpellChecker. BUG=619452 TEST=n/a; no behavior change Committed: https://crrev.com/01554f3c62b7725817c766dd620e302fcdad6e00 Cr-Commit-Position: refs/heads/master@{#408912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Xiaocheng
PTAL.
4 years, 4 months ago (2016-08-01 04:48:00 UTC) #7
yosin_UTC9
lgtm
4 years, 4 months ago (2016-08-01 05:11:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198733003/1
4 years, 4 months ago (2016-08-01 05:11:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 05:15:02 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 05:17:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01554f3c62b7725817c766dd620e302fcdad6e00
Cr-Commit-Position: refs/heads/master@{#408912}

Powered by Google App Engine
This is Rietveld 408576698