Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2198733002: Make the ARC opt-in preference not synced. (Closed)

Created:
4 years, 4 months ago by dspaid
Modified:
4 years, 4 months ago
Reviewers:
hidehiko
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the ARC opt-in preference not synced. If we sync the ARC opt-in prefence we may cause unintentional data loss when the user opts-out of ARC on one device. BUG=633017 TEST=Manually test by opting out of ARC on one machine and observing a second (opted-in) machine's state. Committed: https://crrev.com/1c7841e8e0322b8c3599710e017ff0fb38ab056f Cr-Commit-Position: refs/heads/master@{#408909}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dspaid
4 years, 4 months ago (2016-08-01 01:53:37 UTC) #2
hidehiko
lgtm
4 years, 4 months ago (2016-08-01 03:50:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198733002/1
4 years, 4 months ago (2016-08-01 03:54:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 04:42:31 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1c7841e8e0322b8c3599710e017ff0fb38ab056f Cr-Commit-Position: refs/heads/master@{#408909}
4 years, 4 months ago (2016-08-01 04:44:29 UTC) #8
khmel
4 years, 4 months ago (2016-08-04 18:29:30 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2215943002/ by khmel@chromium.org.

The reason for reverting is: This introduces UI regression (Arc start
notification is shown on each device on each update). Also this breaks UMA
statistics..

Powered by Google App Engine
This is Rietveld 408576698