Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1789)

Issue 2198693002: Flip remaining builders to GN. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip remaining builders to GN. (Apart from the dedicated GYP builders, of course). This affects: - chromium.fyi - Closure Compilation Linux - CrWinAsan - CrWinAsan(dll) - CrWinAsanCov - chromium.lkgr - Win ASan Release Coverage - Win ASan Release Media - Win ASan Release - chromium.mac - ios-simulator - chromium.memory.full - Chromium Windows Builder (DrMemory x64) - Chromium Windows Builder (DrMemory) - tryserver.chromium.linux - closure_compilation - tryserver.chromium.mac - ios-simulator Though the closure compilation builder doesn't really use GN or MB yet. TBR=brettw@chromium.org BUG=605318, 621708 Committed: https://crrev.com/a5a29eae56fe805e78220d5f071050dded5dee35 Cr-Commit-Position: refs/heads/master@{#408890}

Patch Set 1 #

Patch Set 2 : add in ios builder change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M ios/build/bots/chromium.mac/ios-simulator.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/mb/mb_config.pyl View 12 chunks +33 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dirk Pranke
4 years, 4 months ago (2016-07-31 19:51:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198693002/20001
4 years, 4 months ago (2016-07-31 19:52:01 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-31 20:54:50 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a5a29eae56fe805e78220d5f071050dded5dee35 Cr-Commit-Position: refs/heads/master@{#408890}
4 years, 4 months ago (2016-07-31 20:56:36 UTC) #6
brettw
4 years, 4 months ago (2016-07-31 23:25:00 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698