Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2198633002: Add stylus_protocol dependency. (Closed)

Created:
4 years, 4 months ago by rickyz (no longer on Chrome)
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add stylus_protocol dependency. BUG=None Committed: https://crrev.com/2032a2f00eac4b8b79fbcb9a86bf9d8f1c40c22c Cr-Commit-Position: refs/heads/master@{#408858}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/exo.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
rickyz (no longer on Chrome)
Hopefully gyp will go away entirely soon, but adding this to keep it building for ...
4 years, 4 months ago (2016-07-30 00:34:51 UTC) #2
denniskempin
Oh, I missed that. Thank you rickyz! lgtm
4 years, 4 months ago (2016-07-30 01:11:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198633002/1
4 years, 4 months ago (2016-07-30 01:46:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/228223)
4 years, 4 months ago (2016-07-30 01:52:00 UTC) #8
rickyz (no longer on Chrome)
+reveman for OWNERS
4 years, 4 months ago (2016-07-30 02:09:18 UTC) #11
reveman
lgtm
4 years, 4 months ago (2016-07-30 03:47:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198633002/1
4 years, 4 months ago (2016-07-30 03:47:46 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-30 03:51:24 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 03:53:15 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2032a2f00eac4b8b79fbcb9a86bf9d8f1c40c22c
Cr-Commit-Position: refs/heads/master@{#408858}

Powered by Google App Engine
This is Rietveld 408576698