|
|
Created:
4 years, 4 months ago by rickyz (no longer on Chrome) Modified:
4 years, 4 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd stylus_protocol dependency.
BUG=None
Committed: https://crrev.com/2032a2f00eac4b8b79fbcb9a86bf9d8f1c40c22c
Cr-Commit-Position: refs/heads/master@{#408858}
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
rickyz@chromium.org changed reviewers: + denniskempin@chromium.org
Hopefully gyp will go away entirely soon, but adding this to keep it building for now.
denniskempin@google.com changed reviewers: + denniskempin@google.com
Oh, I missed that. Thank you rickyz! lgtm
The CQ bit was checked by rickyz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Add stylus_protocol dependency. BUG=None ========== to ========== Add stylus_protocol dependency. BUG=None ==========
rickyz@chromium.org changed reviewers: + reveman@chromium.org
+reveman for OWNERS
The CQ bit was checked by reveman@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add stylus_protocol dependency. BUG=None ========== to ========== Add stylus_protocol dependency. BUG=None ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add stylus_protocol dependency. BUG=None ========== to ========== Add stylus_protocol dependency. BUG=None Committed: https://crrev.com/2032a2f00eac4b8b79fbcb9a86bf9d8f1c40c22c Cr-Commit-Position: refs/heads/master@{#408858} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2032a2f00eac4b8b79fbcb9a86bf9d8f1c40c22c Cr-Commit-Position: refs/heads/master@{#408858} |