Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2198613002: [Android] Get rid of old perf test runner. (Closed)

Created:
4 years, 4 months ago by rnephew (Reviews Here)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Get rid of old perf test runner. BUG=615157 Committed: https://crrev.com/3a1dfbd039fcb3472bda2a565df92f4d35e79c55 Cr-Commit-Position: refs/heads/master@{#414158}

Patch Set 1 #

Total comments: 2

Patch Set 2 : get rid of test_env #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -711 lines) Patch
D build/android/pylib/perf/setup.py View 1 chunk +0 lines, -105 lines 0 comments Download
D build/android/pylib/perf/test_options.py View 1 chunk +0 lines, -24 lines 0 comments Download
D build/android/pylib/perf/test_runner.py View 1 chunk +0 lines, -453 lines 0 comments Download
D build/android/pylib/utils/test_environment.py View 1 1 chunk +0 lines, -53 lines 0 comments Download
M build/android/test_runner.py View 4 chunks +0 lines, -72 lines 0 comments Download
M build/android/test_runner.pydeps View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
rnephew (Reviews Here)
Do not plan to commit this until the platform mode CL is in place for ...
4 years, 4 months ago (2016-07-29 23:41:54 UTC) #2
jbudorick
https://codereview.chromium.org/2198613002/diff/1/build/android/test_runner.pydeps File build/android/test_runner.pydeps (left): https://codereview.chromium.org/2198613002/diff/1/build/android/test_runner.pydeps#oldcode144 build/android/test_runner.pydeps:144: pylib/utils/test_environment.py This file wasn't deleted in this CL, but ...
4 years, 4 months ago (2016-07-29 23:44:36 UTC) #3
rnephew (Reviews Here)
https://codereview.chromium.org/2198613002/diff/1/build/android/test_runner.pydeps File build/android/test_runner.pydeps (left): https://codereview.chromium.org/2198613002/diff/1/build/android/test_runner.pydeps#oldcode144 build/android/test_runner.pydeps:144: pylib/utils/test_environment.py On 2016/07/29 23:44:35, jbudorick wrote: > This file ...
4 years, 4 months ago (2016-07-29 23:47:02 UTC) #4
perezju
On 2016/07/29 23:47:02, rnephew (Reviews Here) wrote: > https://codereview.chromium.org/2198613002/diff/1/build/android/test_runner.pydeps > File build/android/test_runner.pydeps (left): > > ...
4 years, 4 months ago (2016-08-09 12:22:18 UTC) #5
jbudorick
On 2016/08/09 12:22:18, perezju wrote: > On 2016/07/29 23:47:02, rnephew (Reviews Here) wrote: > > ...
4 years, 4 months ago (2016-08-09 12:57:08 UTC) #6
perezju
On 2016/08/09 12:57:08, jbudorick wrote: > On 2016/08/09 12:22:18, perezju wrote: > > On 2016/07/29 ...
4 years, 4 months ago (2016-08-09 13:04:59 UTC) #7
rnephew (Reviews Here)
On 2016/08/09 13:04:59, perezju wrote: > On 2016/08/09 12:57:08, jbudorick wrote: > > On 2016/08/09 ...
4 years, 4 months ago (2016-08-16 18:38:54 UTC) #8
jbudorick
lgtm, warn the perfbot sheriff
4 years, 4 months ago (2016-08-16 18:49:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198613002/20001
4 years, 4 months ago (2016-08-24 18:13:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-24 21:53:18 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 21:54:43 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a1dfbd039fcb3472bda2a565df92f4d35e79c55
Cr-Commit-Position: refs/heads/master@{#414158}

Powered by Google App Engine
This is Rietveld 408576698