|
|
DescriptionAllow handles through for official builds too (partial revert)
This is a (very) partial revert of
https://codereview.chromium.org/1291553003 to fix the crash reported in
https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I
started trying to dig into making renderers log, but it's still a hairy
mess.
R=wfh@chromium.org
BUG=625172, 358267, 579196
TEST=out\Release\chrome.exe http://www.bbc.co.uk/news/world-asia-china-36189636 --enable-logging=stderr > log.txt 2>&1 where chrome is is_official_build=true shouldn't crash.
Committed: https://crrev.com/5f2967d15fe53b2bd0cec15dd22fdff3b86e1ca9
Cr-Commit-Position: refs/heads/master@{#409318}
Patch Set 1 #Patch Set 2 : delete some xp/vista code #
Total comments: 2
Patch Set 3 : remove #include #
Messages
Total messages: 33 (19 generated)
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
test= line or what behavior does this change?
Description was changed from ========== Allow handles through for official builds too (partial revert) This is a (very) partial revert of https://codereview.chromium.org/1291553003 to fix the crash reported in https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I started trying to dig into making renderers log, but it's still a hairy mess. R=wfh@chromium.org BUG=625172 ========== to ========== Allow handles through for official builds too (partial revert) This is a (very) partial revert of https://codereview.chromium.org/1291553003 to fix the crash reported in https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I started trying to dig into making renderers log, but it's still a hairy mess. R=wfh@chromium.org BUG=625172 TEST=out\Release\chrome.exe http://www.bbc.co.uk/news/world-asia-china-36189636 --enable-logging=stderr > log.txt 2>&1 where chrome is is_official_build=true shouldn't crash. ==========
Added test= line.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by scottmg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wfh@chromium.org Link to the patchset: https://codereview.chromium.org/2198603002/#ps20001 (title: "delete some xp/vista code")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Allow handles through for official builds too (partial revert) This is a (very) partial revert of https://codereview.chromium.org/1291553003 to fix the crash reported in https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I started trying to dig into making renderers log, but it's still a hairy mess. R=wfh@chromium.org BUG=625172 TEST=out\Release\chrome.exe http://www.bbc.co.uk/news/world-asia-china-36189636 --enable-logging=stderr > log.txt 2>&1 where chrome is is_official_build=true shouldn't crash. ========== to ========== Allow handles through for official builds too (partial revert) This is a (very) partial revert of https://codereview.chromium.org/1291553003 to fix the crash reported in https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I started trying to dig into making renderers log, but it's still a hairy mess. R=wfh@chromium.org BUG=625172, 358267 TEST=out\Release\chrome.exe http://www.bbc.co.uk/news/world-asia-china-36189636 --enable-logging=stderr > log.txt 2>&1 where chrome is is_official_build=true shouldn't crash. ==========
scottmg@chromium.org changed reviewers: + sky@chromium.org, thestig@chromium.org
+sky for content/test/content_browser_test_test.cc +thestig for base/process/launch_win.cc (removing xp/vista code)
Description was changed from ========== Allow handles through for official builds too (partial revert) This is a (very) partial revert of https://codereview.chromium.org/1291553003 to fix the crash reported in https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I started trying to dig into making renderers log, but it's still a hairy mess. R=wfh@chromium.org BUG=625172, 358267 TEST=out\Release\chrome.exe http://www.bbc.co.uk/news/world-asia-china-36189636 --enable-logging=stderr > log.txt 2>&1 where chrome is is_official_build=true shouldn't crash. ========== to ========== Allow handles through for official builds too (partial revert) This is a (very) partial revert of https://codereview.chromium.org/1291553003 to fix the crash reported in https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I started trying to dig into making renderers log, but it's still a hairy mess. R=wfh@chromium.org BUG=625172, 358267, 579196 TEST=out\Release\chrome.exe http://www.bbc.co.uk/news/world-asia-china-36189636 --enable-logging=stderr > log.txt 2>&1 where chrome is is_official_build=true shouldn't crash. ==========
lgtm
LGTM https://codereview.chromium.org/2198603002/diff/20001/content/test/content_br... File content/test/content_browser_test_test.cc (right): https://codereview.chromium.org/2198603002/diff/20001/content/test/content_br... content/test/content_browser_test_test.cc:29: #include "base/win/windows_version.h" If you can, remove this.
Thanks https://codereview.chromium.org/2198603002/diff/20001/content/test/content_br... File content/test/content_browser_test_test.cc (right): https://codereview.chromium.org/2198603002/diff/20001/content/test/content_br... content/test/content_browser_test_test.cc:29: #include "base/win/windows_version.h" On 2016/08/02 16:34:46, sky wrote: > If you can, remove this. Done.
The CQ bit was checked by scottmg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org, sky@chromium.org, wfh@chromium.org Link to the patchset: https://codereview.chromium.org/2198603002/#ps40001 (title: "remove #include")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Allow handles through for official builds too (partial revert) This is a (very) partial revert of https://codereview.chromium.org/1291553003 to fix the crash reported in https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I started trying to dig into making renderers log, but it's still a hairy mess. R=wfh@chromium.org BUG=625172, 358267, 579196 TEST=out\Release\chrome.exe http://www.bbc.co.uk/news/world-asia-china-36189636 --enable-logging=stderr > log.txt 2>&1 where chrome is is_official_build=true shouldn't crash. ========== to ========== Allow handles through for official builds too (partial revert) This is a (very) partial revert of https://codereview.chromium.org/1291553003 to fix the crash reported in https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I started trying to dig into making renderers log, but it's still a hairy mess. R=wfh@chromium.org BUG=625172, 358267, 579196 TEST=out\Release\chrome.exe http://www.bbc.co.uk/news/world-asia-china-36189636 --enable-logging=stderr > log.txt 2>&1 where chrome is is_official_build=true shouldn't crash. ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Allow handles through for official builds too (partial revert) This is a (very) partial revert of https://codereview.chromium.org/1291553003 to fix the crash reported in https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I started trying to dig into making renderers log, but it's still a hairy mess. R=wfh@chromium.org BUG=625172, 358267, 579196 TEST=out\Release\chrome.exe http://www.bbc.co.uk/news/world-asia-china-36189636 --enable-logging=stderr > log.txt 2>&1 where chrome is is_official_build=true shouldn't crash. ========== to ========== Allow handles through for official builds too (partial revert) This is a (very) partial revert of https://codereview.chromium.org/1291553003 to fix the crash reported in https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I started trying to dig into making renderers log, but it's still a hairy mess. R=wfh@chromium.org BUG=625172, 358267, 579196 TEST=out\Release\chrome.exe http://www.bbc.co.uk/news/world-asia-china-36189636 --enable-logging=stderr > log.txt 2>&1 where chrome is is_official_build=true shouldn't crash. Committed: https://crrev.com/5f2967d15fe53b2bd0cec15dd22fdff3b86e1ca9 Cr-Commit-Position: refs/heads/master@{#409318} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/5f2967d15fe53b2bd0cec15dd22fdff3b86e1ca9 Cr-Commit-Position: refs/heads/master@{#409318}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2767663002/ by scottmg@chromium.org. The reason for reverting is: Potentially causing https://crbug.com/645319.. |