Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Issue 2198603002: Allow handles through for official builds too (partial revert) (Closed)

Created:
4 years, 4 months ago by scottmg
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, sky, Will Harris
CC:
chromium-reviews, jam, darin-cc_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow handles through for official builds too (partial revert) This is a (very) partial revert of https://codereview.chromium.org/1291553003 to fix the crash reported in https://bugs.chromium.org/p/chromium/issues/detail?id=625172#c21. I started trying to dig into making renderers log, but it's still a hairy mess. R=wfh@chromium.org BUG=625172, 358267, 579196 TEST=out\Release\chrome.exe http://www.bbc.co.uk/news/world-asia-china-36189636 --enable-logging=stderr > log.txt 2>&1 where chrome is is_official_build=true shouldn't crash. Committed: https://crrev.com/5f2967d15fe53b2bd0cec15dd22fdff3b86e1ca9 Cr-Commit-Position: refs/heads/master@{#409318}

Patch Set 1 #

Patch Set 2 : delete some xp/vista code #

Total comments: 2

Patch Set 3 : remove #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -21 lines) Patch
M base/process/launch_win.cc View 1 1 chunk +1 line, -8 lines 0 comments Download
M content/common/sandbox_win.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/content_browser_test_test.cc View 1 2 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 33 (19 generated)
scottmg
4 years, 4 months ago (2016-07-29 23:26:27 UTC) #1
Will Harris
test= line or what behavior does this change?
4 years, 4 months ago (2016-07-30 00:24:29 UTC) #4
scottmg
Added test= line.
4 years, 4 months ago (2016-07-30 00:29:47 UTC) #6
Will Harris
lgtm
4 years, 4 months ago (2016-07-30 00:50:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198603002/20001
4 years, 4 months ago (2016-08-01 23:33:10 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/228933)
4 years, 4 months ago (2016-08-01 23:39:03 UTC) #18
scottmg
+sky for content/test/content_browser_test_test.cc +thestig for base/process/launch_win.cc (removing xp/vista code)
4 years, 4 months ago (2016-08-01 23:44:56 UTC) #21
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-02 00:00:27 UTC) #23
sky
LGTM https://codereview.chromium.org/2198603002/diff/20001/content/test/content_browser_test_test.cc File content/test/content_browser_test_test.cc (right): https://codereview.chromium.org/2198603002/diff/20001/content/test/content_browser_test_test.cc#newcode29 content/test/content_browser_test_test.cc:29: #include "base/win/windows_version.h" If you can, remove this.
4 years, 4 months ago (2016-08-02 16:34:47 UTC) #24
scottmg
Thanks https://codereview.chromium.org/2198603002/diff/20001/content/test/content_browser_test_test.cc File content/test/content_browser_test_test.cc (right): https://codereview.chromium.org/2198603002/diff/20001/content/test/content_browser_test_test.cc#newcode29 content/test/content_browser_test_test.cc:29: #include "base/win/windows_version.h" On 2016/08/02 16:34:46, sky wrote: > ...
4 years, 4 months ago (2016-08-02 19:15:31 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198603002/40001
4 years, 4 months ago (2016-08-02 19:16:37 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-02 20:49:20 UTC) #30
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/5f2967d15fe53b2bd0cec15dd22fdff3b86e1ca9 Cr-Commit-Position: refs/heads/master@{#409318}
4 years, 4 months ago (2016-08-02 20:51:38 UTC) #32
scottmg
3 years, 9 months ago (2017-03-21 18:20:13 UTC) #33
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2767663002/ by scottmg@chromium.org.

The reason for reverting is: Potentially causing https://crbug.com/645319..

Powered by Google App Engine
This is Rietveld 408576698