Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: build/get_landmines.py

Issue 2198583002: Revert of Simplify landmines code a bit now that all branches of all platforms are on ninja (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/landmine_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/get_landmines.py
diff --git a/build/get_landmines.py b/build/get_landmines.py
index 613f2d1facc9a94a40d50bb7573be2e2ab72837d..395c18f4fd71fe4e86526cdad459f9752494cef1 100755
--- a/build/get_landmines.py
+++ b/build/get_landmines.py
@@ -30,26 +30,27 @@
# dependency problems, fix the dependency problems instead of adding a
# landmine.
- if distributor() == 'goma' and platform() == 'win32':
+ if (distributor() == 'goma' and platform() == 'win32' and
+ builder() == 'ninja'):
print 'Need to clobber winja goma due to backend cwd cache fix.'
if platform() == 'android':
print 'Clobber: to handle new way of suppressing findbugs failures.'
print 'Clobber to fix gyp not rename package name (crbug.com/457038)'
- if platform() == 'win':
+ if platform() == 'win' and builder() == 'ninja':
print 'Compile on cc_unittests fails due to symbols removed in r185063.'
- if platform() == 'linux':
+ if platform() == 'linux' and builder() == 'ninja':
print 'Builders switching from make to ninja will clobber on this.'
if platform() == 'mac':
print 'Switching from bundle to unbundled dylib (issue 14743002).'
if platform() in ('win', 'mac'):
print ('Improper dependency for create_nmf.py broke in r240802, '
'fixed in r240860.')
- if (platform() == 'win' and
+ if (platform() == 'win' and builder() == 'ninja' and
gyp_msvs_version() == '2012' and
gyp_defines().get('target_arch') == 'x64' and
gyp_defines().get('dcheck_always_on') == '1'):
print "Switched win x64 trybots from VS2010 to VS2012."
- if (platform() == 'win' and
+ if (platform() == 'win' and builder() == 'ninja' and
gyp_msvs_version().startswith('2013')):
print "Switch to VS2013"
if (platform() == 'win' and gyp_msvs_version().startswith('2015')):
« no previous file with comments | « no previous file | build/landmine_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698