Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2198583002: Revert of Simplify landmines code a bit now that all branches of all platforms are on ninja (Closed)

Created:
4 years, 4 months ago by brettw
Modified:
4 years, 4 months ago
Reviewers:
iannucci, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Simplify landmines code a bit now that all branches of all platforms are on ninja (patchset #2 id:20001 of https://codereview.chromium.org/2071463002/ ) Reason for revert: I just synced on Windows and this is giving me: ________ running 'D:\depot_tools\python276_bin\python.exe src/build/landmines.py ' in 'D:\src\src1' Traceback (most recent call last): File "D:\src\src1\src\build\get_landmines.py", line 16, in <module> builder = landmine_utils.builder AttributeError: 'module' object has no attribute 'builder' Clobbering due to: --- old_landmines Tue Aug 12 16:34:51 2014 +++ new_landmines Fri Jul 29 15:16:56 2016 @@ -1,17 +0,0 @@ -Compile on cc_unittests fails due to symbols removed in r185063. -Improper dependency for create_nmf.py broke in r240802, fixed in r240860. -Switch to VS2015 Update 2 -Need to clobber everything due to an IDL change in r154579 (blink) -Need to clobber everything due to gen file moves in r175513 (Blink) -Clobber to get rid of obselete test plugin after r248358 -Clobber to rebuild GN files for V8 -Clobber to get rid of stale generated mojom.h files -Need to clobber everything due to build_nexe change in nacl r13424 -[chromium-dev] PSA: clobber build needed for IDR_INSPECTOR_* compil... -blink_resources.grd changed: crbug.com/400860 -ninja dependency cycle: crbug.com/408192 -Clobber to fix missing NaCl gyp dependencies (crbug.com/427427). -Another clobber for missing NaCl gyp deps (crbug.com/427427). -Clobber to fix GN not picking up increased ID range (crbug.com/444902) -Remove NaCl toolchains from the output dir (crbug.com/456902) -Clobber to delete stale generated files (crbug.com/510086) Original issue's description: > Simplify landmines code a bit now that all branches of all platforms are on ninja > > BUG=none > > Committed: https://crrev.com/7491d14275670fad399837445b6c1e76ff498a50 > Cr-Commit-Position: refs/heads/master@{#408739} TBR=iannucci@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/8a049c09cbc55b069e41eee94e63d31aa609d927 Cr-Commit-Position: refs/heads/master@{#408784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -18 lines) Patch
M build/get_landmines.py View 1 chunk +6 lines, -5 lines 0 comments Download
M build/landmine_utils.py View 2 chunks +35 lines, -4 lines 0 comments Download
M build/landmines.py View 2 chunks +19 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brettw
Created Revert of Simplify landmines code a bit now that all branches of all platforms ...
4 years, 4 months ago (2016-07-29 22:20:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198583002/1
4 years, 4 months ago (2016-07-29 22:20:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 22:24:38 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8a049c09cbc55b069e41eee94e63d31aa609d927 Cr-Commit-Position: refs/heads/master@{#408784}
4 years, 4 months ago (2016-07-29 22:27:11 UTC) #7
iannucci
4 years, 4 months ago (2016-07-29 22:29:53 UTC) #8
Message was sent while issue was closed.
On 2016/07/29 22:27:11, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/8a049c09cbc55b069e41eee94e63d31aa609d927
> Cr-Commit-Position: refs/heads/master@{#408784}

stamp lgtm

Powered by Google App Engine
This is Rietveld 408576698