[Android][Telemetry] Enable ATrace tracing for BattOr Tests.

[Android][Telemetry] Enable ATrace tracing for BattOr Tests.

BUG=632809
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Committed: https://crrev.com/e3cd5640a78c8adad2d84ab4b9b63f67f0f48de5
Cr-Commit-Position: refs/heads/master@{#408773}

[rnephew (Reviews Here), 2016-07-29 19:00:46]

Description was changed from

==========
[Android][Telemetry] Enable ATrace tracing for BattOr Tests.

BUG=632809
==========

to

==========
[Android][Telemetry] Enable ATrace tracing for BattOr Tests.

BUG=632809
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

[rnephew (Reviews Here), 2016-07-29 19:01:02]

The CQ bit was checked by rnephew@chromium.org to run a CQ dry run

[rnephew (Reviews Here), 2016-07-29 19:01:16]

rnephew@chromium.org changed reviewers:
+ aschulman@chromium.org, charliea@chromium.org, nednguyen@google.com

[commit-bot: I haz the power, 2016-07-29 19:02:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2016-07-29 19:05:28]

lgtm

[aschulman, 2016-07-29 19:22:29]

On 2016/07/29 19:05:28, nednguyen wrote:
> lgtm

shouldn't we also select atrace tracing categories? I think all we need at first
is 'sched'. iirc there is a list that we can enter these into somewhere in
telemetry.

[charliea (OOO until 10-5), 2016-07-29 20:20:39]

On 2016/07/29 19:22:29, aschulman wrote:
> On 2016/07/29 19:05:28, nednguyen wrote:
> > lgtm
> 
> shouldn't we also select atrace tracing categories? I think all we need at
first
> is 'sched'. iirc there is a list that we can enter these into somewhere in
> telemetry.

Looking at
https://cs.corp.google.com/github/catapult-project/catapult/telemetry/telemet...,
I don't think there's any current way to specify the systrace categories like
there is for Chrome categories.

[rnephew (Reviews Here), 2016-07-29 20:39:45]

On 2016/07/29 20:20:39, charliea wrote:
> On 2016/07/29 19:22:29, aschulman wrote:
> > On 2016/07/29 19:05:28, nednguyen wrote:
> > > lgtm
> > 
> > shouldn't we also select atrace tracing categories? I think all we need at
> first
> > is 'sched'. iirc there is a list that we can enter these into somewhere in
> > telemetry.
> 
> Looking at
>
https://cs.corp.google.com/github/catapult-project/catapult/telemetry/telemet...,
> I don't think there's any current way to specify the systrace categories like
> there is for Chrome categories.

If I add the line 'options.config.atrace_config.categories = ['sched']' to
battor.py I get the following error:
Traceback (most recent call last):
  File
"/usr/local/google/home/rnephew/chromium/clank/src/third_party/catapult/telemetry/telemetry/value/failure.py",
line 41, in _GetExcInfoFromMessage
    raise Exception(message)
Exception: TraceImportError: The current code cannot handle multiple paths
between the same clock domains. However, this is a valid operation.
    at Object.addClockSyncMarker (/tracing/model/clock_sync_manager.html:173:15)
    at Object.traceClockSyncEvent_
(/tracing/extras/importer/linux_perf/ftrace_importer.html:755:38)
    at Object.eval
(/tracing/extras/importer/linux_perf/ftrace_importer.html:342:16)
    at Object.forEachLine_
(/tracing/extras/importer/linux_perf/ftrace_importer.html:908:17)
    at Object.importClockSyncMarkers
(/tracing/extras/importer/linux_perf/ftrace_importer.html:335:12)
    at Object.runImportClockSyncMarkersOnOneImporter
(/tracing/importer/import.html:175:26)
    at Object.timedNamedFunction (/tracing/base/timing.html:70:18)
    at Object.run (/tracing/base/task.html:71:21)
    at Function.Task.RunSynchronously (/tracing/base/task.html:152:25)
    at Object.importTraces (/tracing/importer/import.html:72:17)


So for now having just 'sched' is broken due to clock sync issues.

[aschulman, 2016-07-29 20:43:51]

On 2016/07/29 20:39:45, rnephew (Reviews Here) wrote:
> On 2016/07/29 20:20:39, charliea wrote:
> > On 2016/07/29 19:22:29, aschulman wrote:
> > > On 2016/07/29 19:05:28, nednguyen wrote:
> > > > lgtm
> > > 
> > > shouldn't we also select atrace tracing categories? I think all we need at
> > first
> > > is 'sched'. iirc there is a list that we can enter these into somewhere in
> > > telemetry.
> > 
> > Looking at
> >
>
https://cs.corp.google.com/github/catapult-project/catapult/telemetry/telemet...,
> > I don't think there's any current way to specify the systrace categories
like
> > there is for Chrome categories.
> 
> If I add the line 'options.config.atrace_config.categories = ['sched']' to
> battor.py I get the following error:
> Traceback (most recent call last):
>   File
>
"/usr/local/google/home/rnephew/chromium/clank/src/third_party/catapult/telemetry/telemetry/value/failure.py",
> line 41, in _GetExcInfoFromMessage
>     raise Exception(message)
> Exception: TraceImportError: The current code cannot handle multiple paths
> between the same clock domains. However, this is a valid operation.
>     at Object.addClockSyncMarker
(/tracing/model/clock_sync_manager.html:173:15)
>     at Object.traceClockSyncEvent_
> (/tracing/extras/importer/linux_perf/ftrace_importer.html:755:38)
>     at Object.eval
> (/tracing/extras/importer/linux_perf/ftrace_importer.html:342:16)
>     at Object.forEachLine_
> (/tracing/extras/importer/linux_perf/ftrace_importer.html:908:17)
>     at Object.importClockSyncMarkers
> (/tracing/extras/importer/linux_perf/ftrace_importer.html:335:12)
>     at Object.runImportClockSyncMarkersOnOneImporter
> (/tracing/importer/import.html:175:26)
>     at Object.timedNamedFunction (/tracing/base/timing.html:70:18)
>     at Object.run (/tracing/base/task.html:71:21)
>     at Function.Task.RunSynchronously (/tracing/base/task.html:152:25)
>     at Object.importTraces (/tracing/importer/import.html:72:17)
> 
> 
> So for now having just 'sched' is broken due to clock sync issues.

I see, so what categories do we have by default?

[rnephew (Reviews Here), 2016-07-29 20:46:11]

On 2016/07/29 20:43:51, aschulman wrote:
> On 2016/07/29 20:39:45, rnephew (Reviews Here) wrote:
> > On 2016/07/29 20:20:39, charliea wrote:
> > > On 2016/07/29 19:22:29, aschulman wrote:
> > > > On 2016/07/29 19:05:28, nednguyen wrote:
> > > > > lgtm
> > > > 
> > > > shouldn't we also select atrace tracing categories? I think all we need
at
> > > first
> > > > is 'sched'. iirc there is a list that we can enter these into somewhere
in
> > > > telemetry.
> > > 
> > > Looking at
> > >
> >
>
https://cs.corp.google.com/github/catapult-project/catapult/telemetry/telemet...,
> > > I don't think there's any current way to specify the systrace categories
> like
> > > there is for Chrome categories.
> > 
> > If I add the line 'options.config.atrace_config.categories = ['sched']' to
> > battor.py I get the following error:
> > Traceback (most recent call last):
> >   File
> >
>
"/usr/local/google/home/rnephew/chromium/clank/src/third_party/catapult/telemetry/telemetry/value/failure.py",
> > line 41, in _GetExcInfoFromMessage
> >     raise Exception(message)
> > Exception: TraceImportError: The current code cannot handle multiple paths
> > between the same clock domains. However, this is a valid operation.
> >     at Object.addClockSyncMarker
> (/tracing/model/clock_sync_manager.html:173:15)
> >     at Object.traceClockSyncEvent_
> > (/tracing/extras/importer/linux_perf/ftrace_importer.html:755:38)
> >     at Object.eval
> > (/tracing/extras/importer/linux_perf/ftrace_importer.html:342:16)
> >     at Object.forEachLine_
> > (/tracing/extras/importer/linux_perf/ftrace_importer.html:908:17)
> >     at Object.importClockSyncMarkers
> > (/tracing/extras/importer/linux_perf/ftrace_importer.html:335:12)
> >     at Object.runImportClockSyncMarkersOnOneImporter
> > (/tracing/importer/import.html:175:26)
> >     at Object.timedNamedFunction (/tracing/base/timing.html:70:18)
> >     at Object.run (/tracing/base/task.html:71:21)
> >     at Function.Task.RunSynchronously (/tracing/base/task.html:152:25)
> >     at Object.importTraces (/tracing/importer/import.html:72:17)
> > 
> > 
> > So for now having just 'sched' is broken due to clock sync issues.
> 
> I see, so what categories do we have by default?

https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...

It looks like it sets it to None by default; which I assume means everything.
Adding Alex who wrote the atrace tracing agent.

[rnephew (Reviews Here), 2016-07-29 20:46:22]

rnephew@chromium.org changed reviewers:
+ alexandermont@chromium.org

[rnephew (Reviews Here), 2016-07-29 20:48:34]

On 2016/07/29 20:46:22, rnephew (Reviews Here) wrote:

It seems very strange that it is complaining about having multiple paths to the
same clock domain when I set just 'sched'. It only calls RecordClockSyncMarker
once.

[commit-bot: I haz the power, 2016-07-29 21:21:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 21:21:42]

Dry run: This issue passed the CQ dry run.

[rnephew (Reviews Here), 2016-07-29 21:32:22]

The CQ bit was checked by rnephew@chromium.org

[commit-bot: I haz the power, 2016-07-29 21:32:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 21:37:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-29 21:38:26]

Description was changed from

==========
[Android][Telemetry] Enable ATrace tracing for BattOr Tests.

BUG=632809
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

to

==========
[Android][Telemetry] Enable ATrace tracing for BattOr Tests.

BUG=632809
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Committed: https://crrev.com/e3cd5640a78c8adad2d84ab4b9b63f67f0f48de5
Cr-Commit-Position: refs/heads/master@{#408773}
==========

[commit-bot: I haz the power, 2016-07-29 21:38:27]

Patchset 1 (id:??) landed as
https://crrev.com/e3cd5640a78c8adad2d84ab4b9b63f67f0f48de5
Cr-Commit-Position: refs/heads/master@{#408773}