Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: chrome/browser/extensions/component_loader.cc

Issue 21985002: Add Finch Checks to the State Machine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SMLog
Patch Set: CR Feedback Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/component_loader.cc
diff --git a/chrome/browser/extensions/component_loader.cc b/chrome/browser/extensions/component_loader.cc
index 07eb949b0e69c38a01ceba74fb48737c338fbde4..66cc7b0cf460ba2ee1db490f951bda953028cd9d 100644
--- a/chrome/browser/extensions/component_loader.cc
+++ b/chrome/browser/extensions/component_loader.cc
@@ -468,7 +468,10 @@ void ComponentLoader::AddDefaultComponentExtensionsWithBackgroundPages(
#endif // defined(OS_CHROMEOS)
#if defined(ENABLE_GOOGLE_NOW)
- if (base::FieldTrialList::FindFullName("GoogleNow") == "Enable" ||
+ std::string fieldTrialResult =
+ base::FieldTrialList::FindFullName("GoogleNow");
+ if ((fieldTrialResult == "Enable") ||
+ (fieldTrialResult == "EnabledViaFlag") ||
vadimt 2013/08/03 02:07:53 There will be a group 'EnableWithBackground'. I'd
robliao 2013/08/09 21:46:44 Done.
CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableGoogleNowIntegration)) {
Add(IDR_GOOGLE_NOW_MANIFEST,
« no previous file with comments | « no previous file | chrome/browser/resources/google_now/background.js » ('j') | chrome/browser/resources/google_now/background.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698