[turbofan] Add support for accessor inlining.

[turbofan] Add support for accessor inlining.

Allow inlining of getters and setters into TurboFan optimized code.
This just adds the basic machinery required to essentially inline
the setter and getter dispatch code for the (keyed) load/store ICs.
There'll be follow up CLs to also actually inline some of the interesting
accessor functions itself, like the byteLength and friends for the
TypedArrays.

R=jarin@chromium.org

Committed: https://crrev.com/35a195e1098d6cdd817e3f8482ceedaeeea610fa
Cr-Commit-Position: refs/heads/master@{#38192}

[Benedikt Meurer, 2016-07-29 17:21:18]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 17:21:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 17:35:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 17:35:31]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Benedikt Meurer, 2016-07-29 18:36:38]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 18:36:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 18:47:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 18:47:55]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Benedikt Meurer, 2016-08-01 05:13:02]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 05:13:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-08-01 05:15:42]

Description was changed from

==========
[WIP] Accessors!
==========

to

==========
[turbofan] Add support for accessor inlining.

Allow inlining of getters and setters into TurboFan optimized code.
This just adds the basic machinery required to essentially inline
the setter and getter dispatch code for the (keyed) load/store ICs.
There'll be follow up CLs to also actually inline some of the interesting
accessor functions itself, like the byteLength and friends for the
TypedArrays.

R=jarin@chromium.org
==========

[Benedikt Meurer, 2016-08-01 05:15:42]

bmeurer@chromium.org changed reviewers:
+ jarin@chromium.org

[commit-bot: I haz the power, 2016-08-01 05:27:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 05:27:43]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/9987)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/5973)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[Jarin, 2016-08-01 05:37:54]

https://codereview.chromium.org/2198473002/diff/20001/src/compiler/js-native-...
File src/compiler/js-native-context-specialization.cc (right):

https://codereview.chromium.org/2198473002/diff/20001/src/compiler/js-native-...
src/compiler/js-native-context-specialization.cc:765: // TODO(bmeurer): Properly
rewire the IfException edge here if there's any.
Please, write a test that guards this TODO.

https://codereview.chromium.org/2198473002/diff/40001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/2198473002/diff/40001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.cc:2306: ast_context()->GetStateCombine());
Should be Push (here and below). Could you write a test for property access
within effect context + deopt from accessor?

[Benedikt Meurer, 2016-08-01 06:16:06]

https://codereview.chromium.org/2198473002/diff/20001/src/compiler/js-native-...
File src/compiler/js-native-context-specialization.cc (right):

https://codereview.chromium.org/2198473002/diff/20001/src/compiler/js-native-...
src/compiler/js-native-context-specialization.cc:765: // TODO(bmeurer): Properly
rewire the IfException edge here if there's any.
On 2016/08/01 05:37:54, Jarin wrote:
> Please, write a test that guards this TODO.

Done.

https://codereview.chromium.org/2198473002/diff/40001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/2198473002/diff/40001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.cc:2306: ast_context()->GetStateCombine());
On 2016/08/01 05:37:54, Jarin wrote:
> Should be Push (here and below). Could you write a test for property access
> within effect context + deopt from accessor?

Done.

[Benedikt Meurer, 2016-08-01 06:36:43]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 06:36:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2016-08-01 06:40:16]

lgtm

[Benedikt Meurer, 2016-08-01 06:42:58]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2016-08-01 06:43:05]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-08-01 06:43:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 06:59:39]

Description was changed from

==========
[turbofan] Add support for accessor inlining.

Allow inlining of getters and setters into TurboFan optimized code.
This just adds the basic machinery required to essentially inline
the setter and getter dispatch code for the (keyed) load/store ICs.
There'll be follow up CLs to also actually inline some of the interesting
accessor functions itself, like the byteLength and friends for the
TypedArrays.

R=jarin@chromium.org
==========

to

==========
[turbofan] Add support for accessor inlining.

Allow inlining of getters and setters into TurboFan optimized code.
This just adds the basic machinery required to essentially inline
the setter and getter dispatch code for the (keyed) load/store ICs.
There'll be follow up CLs to also actually inline some of the interesting
accessor functions itself, like the byteLength and friends for the
TypedArrays.

R=jarin@chromium.org
==========

[commit-bot: I haz the power, 2016-08-01 06:59:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-01 07:00:02]

Description was changed from

==========
[turbofan] Add support for accessor inlining.

Allow inlining of getters and setters into TurboFan optimized code.
This just adds the basic machinery required to essentially inline
the setter and getter dispatch code for the (keyed) load/store ICs.
There'll be follow up CLs to also actually inline some of the interesting
accessor functions itself, like the byteLength and friends for the
TypedArrays.

R=jarin@chromium.org
==========

to

==========
[turbofan] Add support for accessor inlining.

Allow inlining of getters and setters into TurboFan optimized code.
This just adds the basic machinery required to essentially inline
the setter and getter dispatch code for the (keyed) load/store ICs.
There'll be follow up CLs to also actually inline some of the interesting
accessor functions itself, like the byteLength and friends for the
TypedArrays.

R=jarin@chromium.org

Committed: https://crrev.com/35a195e1098d6cdd817e3f8482ceedaeeea610fa
Cr-Commit-Position: refs/heads/master@{#38192}
==========

[commit-bot: I haz the power, 2016-08-01 07:00:03]

Patchset 4 (id:??) landed as
https://crrev.com/35a195e1098d6cdd817e3f8482ceedaeeea610fa
Cr-Commit-Position: refs/heads/master@{#38192}