Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2198453002: Conditionally define SK_SUPPORT_LEGACY_DATA_FACTORIES. (Closed)

Created:
4 years, 4 months ago by bungeman-skia
Modified:
4 years, 4 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Conditionally define SK_SUPPORT_LEGACY_DATA_FACTORIES. In order to remove this define it will first need to be defined in Chromium. However, doing so causes redefinition warnings as errors. Only define this macro if it is not already defined to avoid this. TBR=reed This doesn't change any API. Committed: https://skia.googlesource.com/skia/+/aa8f39402c1b52202cb06e2c1c247ca4bd5e8afc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M include/core/SkData.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198453002/1
4 years, 4 months ago (2016-07-29 17:05:11 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 17:47:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/aa8f39402c1b52202cb06e2c1c247ca4bd5e8afc

Powered by Google App Engine
This is Rietveld 408576698