Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

Issue 2198443004: [DevTools] Fix location.script().sourceURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: a Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @implements {WebInspector.TargetManager.Observer} 7 * @implements {WebInspector.TargetManager.Observer}
8 * @param {!WebInspector.TargetManager} targetManager 8 * @param {!WebInspector.TargetManager} targetManager
9 * @param {!WebInspector.Workspace} workspace 9 * @param {!WebInspector.Workspace} workspace
10 * @param {!WebInspector.NetworkMapping} networkMapping 10 * @param {!WebInspector.NetworkMapping} networkMapping
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 150
151 /** 151 /**
152 * @param {!WebInspector.DebuggerModel.Location} location 152 * @param {!WebInspector.DebuggerModel.Location} location
153 * @param {function(!WebInspector.LiveLocation)} updateDelegate 153 * @param {function(!WebInspector.LiveLocation)} updateDelegate
154 * @param {!WebInspector.LiveLocationPool} locationPool 154 * @param {!WebInspector.LiveLocationPool} locationPool
155 * @return {!WebInspector.DebuggerWorkspaceBinding.Location} 155 * @return {!WebInspector.DebuggerWorkspaceBinding.Location}
156 */ 156 */
157 createCallFrameLiveLocation: function(location, updateDelegate, locationPool ) 157 createCallFrameLiveLocation: function(location, updateDelegate, locationPool )
158 { 158 {
159 var target = location.target(); 159 var target = location.target();
160 this._ensureInfoForScript(location.script()); 160 this._ensureInfoForScript(/** @type {!WebInspector.Script} */(location.s cript()));
lushnikov 2016/07/30 01:03:06 why are you sure there's a script?
kozy 2016/07/30 01:19:03 I'll address it in followup: crbug.com/632933
161 var liveLocation = this.createLiveLocation(location, updateDelegate, loc ationPool); 161 var liveLocation = this.createLiveLocation(location, updateDelegate, loc ationPool);
162 this._registerCallFrameLiveLocation(target, liveLocation); 162 this._registerCallFrameLiveLocation(target, liveLocation);
163 return liveLocation; 163 return liveLocation;
164 }, 164 },
165 165
166 /** 166 /**
167 * @param {!WebInspector.DebuggerModel.Location} rawLocation 167 * @param {!WebInspector.DebuggerModel.Location} rawLocation
168 * @return {!WebInspector.UILocation} 168 * @return {!WebInspector.UILocation}
169 */ 169 */
170 rawLocationToUILocation: function(rawLocation) 170 rawLocationToUILocation: function(rawLocation)
(...skipping 516 matching lines...) Expand 10 before | Expand all | Expand 10 after
687 * @param {number} lineNumber 687 * @param {number} lineNumber
688 * @return {boolean} 688 * @return {boolean}
689 */ 689 */
690 uiLineHasMapping: function(uiSourceCode, lineNumber) { } 690 uiLineHasMapping: function(uiSourceCode, lineNumber) { }
691 } 691 }
692 692
693 /** 693 /**
694 * @type {!WebInspector.DebuggerWorkspaceBinding} 694 * @type {!WebInspector.DebuggerWorkspaceBinding}
695 */ 695 */
696 WebInspector.debuggerWorkspaceBinding; 696 WebInspector.debuggerWorkspaceBinding;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698