tools/gn/ninja_target_writer.cc - Issue 2198433004: Make get_label_info take into account the toolchain for target_gen_dir

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_target_writer.cc

Issue 2198433004: Make get_label_info take into account the toolchain for target_gen_dir (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unused static function Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/ninja_target_writer.cc

diff --git a/tools/gn/ninja_target_writer.cc b/tools/gn/ninja_target_writer.cc

index ccb3eb7ec7c715c906d12da8f83bf0cae5f18ce4..2b30d6514398ed19ea43dd793e8addcb917a30b3 100644

--- a/tools/gn/ninja_target_writer.cc

+++ b/tools/gn/ninja_target_writer.cc

@@ -262,10 +262,8 @@ OutputFile NinjaTargetWriter::WriteInputDepsStampAndGetDep(

}

// Make a stamp file.

- OutputFile input_stamp_file(

- RebasePath(GetTargetOutputDir(target_).value(),

- settings_->build_settings()->build_dir(),

- settings_->build_settings()->root_path_utf8()));

+ OutputFile input_stamp_file =

+ GetBuildDirForTargetAsOutputFile(target_, BuildDirType::OBJ);

input_stamp_file.value().append(target_->label().name());

input_stamp_file.value().append(".inputdeps.stamp");

« no previous file with comments | « tools/gn/ninja_create_bundle_target_writer.cc ('k') | tools/gn/ninja_utils.cc » ('j') | no next file with comments »