Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2198423002: Clean up default toolchain logic for CrOS GN builds. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
Reviewers:
llozano, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up default toolchain logic for CrOS GN builds. The initial versions of the CrOS GN builds were written when we didn't really understand how the different CrOS builds would work, and we weren't sure what the toolchains needed to look like. We can now safely say that the //build/toolchain/cros:* toolchains should only be used in the simplechrome and ebuild workflows, where `custom_toolchain="//build/toolchain/cros:target"` in the GN args. For "regular" desktop ChromeOS builds, we should just re-use the linux toolchains. R=brettw@chromium.org, llozano@chromium.org BUG=632279 Committed: https://crrev.com/d5b49c1cf6737a33c918e8433c12e19538223f6e Cr-Commit-Position: refs/heads/master@{#409652}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +3 lines, -11 lines 0 comments Download
M build/toolchain/cros/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Dirk Pranke
4 years, 4 months ago (2016-08-01 23:51:39 UTC) #1
brettw
lgtm
4 years, 4 months ago (2016-08-03 22:12:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198423002/1
4 years, 4 months ago (2016-08-03 22:14:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 23:08:46 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 23:10:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5b49c1cf6737a33c918e8433c12e19538223f6e
Cr-Commit-Position: refs/heads/master@{#409652}

Powered by Google App Engine
This is Rietveld 408576698