Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3982)

Unified Diff: chrome/browser/notifications/fullscreen_notification_blocker.cc

Issue 2198363002: Pass Notification into NotificationBlocker ShouldShow* methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ash build errors Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/fullscreen_notification_blocker.cc
diff --git a/chrome/browser/notifications/fullscreen_notification_blocker.cc b/chrome/browser/notifications/fullscreen_notification_blocker.cc
index a0c0a7b45c33512ad7dab941e2de0277ec0691f7..afa369cf6645113a3a0c134455e590540f1e847c 100644
--- a/chrome/browser/notifications/fullscreen_notification_blocker.cc
+++ b/chrome/browser/notifications/fullscreen_notification_blocker.cc
@@ -66,12 +66,12 @@ void FullscreenNotificationBlocker::CheckState() {
}
bool FullscreenNotificationBlocker::ShouldShowNotificationAsPopup(
- const message_center::NotifierId& notifier_id) const {
+ const message_center::Notification& notification) const {
bool enabled = !is_fullscreen_mode_;
#if defined(USE_ASH)
if (ash::Shell::HasInstance())
enabled = enabled || ash::system_notifier::ShouldAlwaysShowPopups(
- notifier_id);
+ notification.notifier_id());
#endif
return enabled;

Powered by Google App Engine
This is Rietveld 408576698