Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 21983003: Make the Mac build work. (Closed)

Created:
7 years, 4 months ago by brettw
Modified:
7 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews, rginda+watch_chromium.org
Visibility:
Public.

Description

Make the Mac build work. This adds some support for objective C invocation. There are some weird harcoded stuff. BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215948

Patch Set 1 #

Total comments: 3

Patch Set 2 : merge #

Patch Set 3 : #

Patch Set 4 : dunnow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -114 lines) Patch
M tools/gn/BUILD.gn View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/gn/config_values.h View 2 chunks +13 lines, -12 lines 0 comments Download
M tools/gn/config_values_generator.h View 2 chunks +2 lines, -7 lines 0 comments Download
M tools/gn/config_values_generator.cc View 4 chunks +17 lines, -33 lines 0 comments Download
M tools/gn/input_file.h View 2 chunks +9 lines, -3 lines 0 comments Download
M tools/gn/input_file.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/input_file_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/input_file_manager.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/gn/ninja_build_writer.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M tools/gn/ninja_helper.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M tools/gn/ninja_target_writer.cc View 2 3 chunks +22 lines, -11 lines 0 comments Download
A tools/gn/secondary/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/gn/secondary/base/BUILD.gn View 13 chunks +59 lines, -15 lines 0 comments Download
M tools/gn/secondary/build/config/BUILDCONFIG.gn View 2 2 chunks +6 lines, -0 lines 0 comments Download
A tools/gn/secondary/build/config/clang/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
M tools/gn/secondary/build/config/compiler/BUILD.gn View 1 2 3 chunks +25 lines, -2 lines 0 comments Download
M tools/gn/secondary/build/config/mac/BUILD.gn View 2 3 chunks +14 lines, -5 lines 0 comments Download
A tools/gn/secondary/third_party/libevent/BUILD.gn View 1 chunk +41 lines, -0 lines 0 comments Download
A + tools/gn/secondary/third_party/mach_override/BUILD.gn View 1 chunk +10 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
7 years, 4 months ago (2013-08-02 21:05:39 UTC) #1
scottmg
lgtm https://codereview.chromium.org/21983003/diff/1/tools/gn/input_file.h File tools/gn/input_file.h (right): https://codereview.chromium.org/21983003/diff/1/tools/gn/input_file.h#newcode18 tools/gn/input_file.h:18: InputFile(const SourceFile& name); explicit? https://codereview.chromium.org/21983003/diff/1/tools/gn/ninja_helper.cc File tools/gn/ninja_helper.cc (right): ...
7 years, 4 months ago (2013-08-05 12:24:47 UTC) #2
brettw
7 years, 4 months ago (2013-08-06 19:36:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r215948 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698