Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2198223002: Mark analysis_server as being strong-mode clean (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M pkg/analysis_server/.analysis_options View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/channel/byte_stream_channel.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/channel/web_socket_channel.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 4 months ago (2016-08-01 19:20:30 UTC) #2
scheglov
LGTM
4 years, 4 months ago (2016-08-01 19:22:04 UTC) #3
Brian Wilkerson
4 years, 4 months ago (2016-08-01 19:23:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1ba4a1e8875d424ea258dc343b720c406170a4ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698