Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 2198193002: Revert of Speculative fix for perf test performance regressions. (Closed)

Created:
4 years, 4 months ago by waffles
Modified:
4 years, 4 months ago
Reviewers:
Will Harris
CC:
chromium-reviews, RyanS
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Speculative fix for perf test performance regressions. (patchset #1 id:1 of https://codereview.chromium.org/2190083002/ ) Reason for revert: This patch has no effect on perf test performance regressions, although it helped me understand what is really going on. I've identified two paths forward and neither of them involves having this behavior; hence, removing it. Original issue's description: > Speculative fix for perf test performance regressions. > > BUG=623804 > > Committed: https://crrev.com/1eadbdccdb0dee6fe9e169ac374bfa6c1ad9d03d > Cr-Commit-Position: refs/heads/master@{#408789} TBR=wfh@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623804 Committed: https://crrev.com/95b8b85ada46836423ff89e97706369981b6d271 Cr-Commit-Position: refs/heads/master@{#409011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
waffles
Created Revert of Speculative fix for perf test performance regressions.
4 years, 4 months ago (2016-08-01 18:05:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198193002/1
4 years, 4 months ago (2016-08-01 18:05:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 18:51:07 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 19:03:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95b8b85ada46836423ff89e97706369981b6d271
Cr-Commit-Position: refs/heads/master@{#409011}

Powered by Google App Engine
This is Rietveld 408576698