infra/bots/recipe_modules/skia/valgrind_flavor.py - Issue 2198173002: Re-organize Skia recipes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: infra/bots/recipe_modules/skia/valgrind_flavor.py

Issue 2198173002: Re-organize Skia recipes (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix missing dependency Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.

4

5

6 import default_flavor

7

8

9 """Utils for running under Valgrind."""

10

11

12 class ValgrindFlavorUtils(default_flavor.DefaultFlavorUtils):

13 def __init__(self, args, *kwargs):

14 super(ValgrindFlavorUtils, self).__init__(args, *kwargs)

15 self._suppressions_file = self._skia_api.skia_dir.join(

16 'tools', 'valgrind.supp')

17

18 def step(self, name, cmd, **kwargs):

19 new_cmd = ['valgrind', '--gen-suppressions=all', '--leak-check=full',

20 '--track-origins=yes', '--error-exitcode=1', '--num-callers=40',

21 '--suppressions=%s' % self._suppressions_file]

22 path_to_app = self.out_dir.join(cmd[0])

23 new_cmd.append(path_to_app)

24 new_cmd.extend(cmd[1:])

25 return self._skia_api.run(self._skia_api.m.step, name, cmd=new_cmd,

26 **kwargs)

27

OLD	NEW