infra/bots/recipe_modules/core/resources/binary_size_utils.py - Issue 2198173002: Re-organize Skia recipes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: infra/bots/recipe_modules/core/resources/binary_size_utils.py

Issue 2198173002: Re-organize Skia recipes (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix missing dependency Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Common utilities for tools that deal with binary size information.	5 """Common utilities for tools that deal with binary size information.

6	6

7 Copied from chromium/src/build/android/pylib/symbols/binary_size_tools.py.	7 Copied from chromium/src/build/android/pylib/symbols/binary_size_tools.py.

8 """	8 """

9	9

10 import logging	10 import logging

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
58 if sym_type in ('U', 'w'):	58 if sym_type in ('U', 'w'):

59 continue # external or weak symbol	59 continue # external or weak symbol

60 match = addr_only_re.match(line)	60 match = addr_only_re.match(line)

61 if match:	61 if match:

62 continue # Nothing to do.	62 continue # Nothing to do.

63	63

64	64

65 # If we reach this part of the loop, there was something in the	65 # If we reach this part of the loop, there was something in the

66 # line that we didn't expect or recognize.	66 # line that we didn't expect or recognize.

67 logging.warning('nm output parser failed to parse: %s', repr(line))	67 logging.warning('nm output parser failed to parse: %s', repr(line))

OLD	NEW