Revert of Change FYI win clang builders from official to official_optimize.

Revert of Change FYI win clang builders from official to official_optimize. (patchset #1 id:1 of https://codereview.chromium.org/2176113005/ )

Do keep the change for CrWinClangGoma, since that bot doesn't run tests.

Reason for revert:
This was landed without review or motivation and breaks tests on these bots.

Original issue's description:
> Change FYI win clang builders from official to official_optimize.
>
> This changes the config settings for the builders so that they don't
> need to pull internal files.
>
> TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org
> NOTRY=true
> BUG=623659, 630095
>
> Committed: https://crrev.com/7a25f5add3515acdd6db3da3d916670e5add63ac
> Cr-Commit-Position: refs/heads/master@{#407862}

TBR=hans@chromium.org,tikuta@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623659, 630095
Committed: https://crrev.com/c83a1c10a6be07c4e05536bccc4b209a696d0b47
Cr-Commit-Position: refs/heads/master@{#409000}

[Nico, 2016-08-01 17:08:34]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-08-01 17:08:35]

Created Revert of Change FYI win clang builders from official to
official_optimize.

[commit-bot: I haz the power, 2016-08-01 17:08:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-08-01 17:10:31]

Description was changed from

==========
Revert of Change FYI win clang builders from official to official_optimize.
(patchset #1 id:1 of https://codereview.chromium.org/2176113005/ )

Reason for revert:
This was landed without review or motivation and breaks tests on these bots.

Original issue's description:
> Change FYI win clang builders from official to official_optimize.
> 
> This changes the config settings for the builders so that they don't
> need to pull internal files.
> 
> TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org
> NOTRY=true
> BUG=623659, 630095
> 
> Committed: https://crrev.com/7a25f5add3515acdd6db3da3d916670e5add63ac
> Cr-Commit-Position: refs/heads/master@{#407862}

TBR=hans@chromium.org,tikuta@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623659, 630095
==========

to

==========
Revert of Change FYI win clang builders from official to official_optimize.
(patchset #1 id:1 of https://codereview.chromium.org/2176113005/ )

Do keep the change for CrWinClangGoma, since that bot doesn't run tests.

Reason for revert:
This was landed without review or motivation and breaks tests on these bots.

Original issue's description:
> Change FYI win clang builders from official to official_optimize.
> 
> This changes the config settings for the builders so that they don't
> need to pull internal files.
> 
> TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org
> NOTRY=true
> BUG=623659, 630095
> 
> Committed: https://crrev.com/7a25f5add3515acdd6db3da3d916670e5add63ac
> Cr-Commit-Position: refs/heads/master@{#407862}

TBR=hans@chromium.org,tikuta@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623659, 630095
==========

[Nico, 2016-08-01 17:12:28]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-08-01 17:12:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-08-01 17:32:45]

The CQ bit was unchecked by dpranke@chromium.org

[Dirk Pranke, 2016-08-01 17:33:15]

Unchecking the box temporarily ...

What tests were broken as a result of this?

[Nico, 2016-08-01 17:51:49]

https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds...
I think?

On Mon, Aug 1, 2016 at 1:33 PM, <dpranke@chromium.org> wrote:

> Unchecking the box temporarily ...
>
> What tests were broken as a result of this?
>
> https://codereview.chromium.org/2198153002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2016-08-01 17:51:54]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-08-01 17:52:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-08-01 17:52:55]

Ah, yeah, I could believe that one would fail.

Okay, lgtm.

[Dirk Pranke, 2016-08-01 17:54:53]

On 2016/08/01 17:52:55, Dirk Pranke wrote:
> Ah, yeah, I could believe that one would fail.
> 
> Okay, lgtm.

Though, that test is broken. That should be keying off of is_chrome_branded, not
is_official_build.

[Dirk Pranke, 2016-08-01 17:55:23]

I'll let you and kerz@ argue over whether this change should land or not ...

[commit-bot: I haz the power, 2016-08-01 18:15:37]

Description was changed from

==========
Revert of Change FYI win clang builders from official to official_optimize.
(patchset #1 id:1 of https://codereview.chromium.org/2176113005/ )

Do keep the change for CrWinClangGoma, since that bot doesn't run tests.

Reason for revert:
This was landed without review or motivation and breaks tests on these bots.

Original issue's description:
> Change FYI win clang builders from official to official_optimize.
> 
> This changes the config settings for the builders so that they don't
> need to pull internal files.
> 
> TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org
> NOTRY=true
> BUG=623659, 630095
> 
> Committed: https://crrev.com/7a25f5add3515acdd6db3da3d916670e5add63ac
> Cr-Commit-Position: refs/heads/master@{#407862}

TBR=hans@chromium.org,tikuta@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623659, 630095
==========

to

==========
Revert of Change FYI win clang builders from official to official_optimize.
(patchset #1 id:1 of https://codereview.chromium.org/2176113005/ )

Do keep the change for CrWinClangGoma, since that bot doesn't run tests.

Reason for revert:
This was landed without review or motivation and breaks tests on these bots.

Original issue's description:
> Change FYI win clang builders from official to official_optimize.
> 
> This changes the config settings for the builders so that they don't
> need to pull internal files.
> 
> TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org
> NOTRY=true
> BUG=623659, 630095
> 
> Committed: https://crrev.com/7a25f5add3515acdd6db3da3d916670e5add63ac
> Cr-Commit-Position: refs/heads/master@{#407862}

TBR=hans@chromium.org,tikuta@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623659, 630095
==========

[commit-bot: I haz the power, 2016-08-01 18:15:38]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-01 18:24:44]

Description was changed from

==========
Revert of Change FYI win clang builders from official to official_optimize.
(patchset #1 id:1 of https://codereview.chromium.org/2176113005/ )

Do keep the change for CrWinClangGoma, since that bot doesn't run tests.

Reason for revert:
This was landed without review or motivation and breaks tests on these bots.

Original issue's description:
> Change FYI win clang builders from official to official_optimize.
> 
> This changes the config settings for the builders so that they don't
> need to pull internal files.
> 
> TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org
> NOTRY=true
> BUG=623659, 630095
> 
> Committed: https://crrev.com/7a25f5add3515acdd6db3da3d916670e5add63ac
> Cr-Commit-Position: refs/heads/master@{#407862}

TBR=hans@chromium.org,tikuta@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623659, 630095
==========

to

==========
Revert of Change FYI win clang builders from official to official_optimize.
(patchset #1 id:1 of https://codereview.chromium.org/2176113005/ )

Do keep the change for CrWinClangGoma, since that bot doesn't run tests.

Reason for revert:
This was landed without review or motivation and breaks tests on these bots.

Original issue's description:
> Change FYI win clang builders from official to official_optimize.
>
> This changes the config settings for the builders so that they don't
> need to pull internal files.
>
> TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org
> NOTRY=true
> BUG=623659, 630095
>
> Committed: https://crrev.com/7a25f5add3515acdd6db3da3d916670e5add63ac
> Cr-Commit-Position: refs/heads/master@{#407862}

TBR=hans@chromium.org,tikuta@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623659, 630095

Committed: https://crrev.com/c83a1c10a6be07c4e05536bccc4b209a696d0b47
Cr-Commit-Position: refs/heads/master@{#409000}
==========

[commit-bot: I haz the power, 2016-08-01 18:24:45]

Patchset 3 (id:??) landed as
https://crrev.com/c83a1c10a6be07c4e05536bccc4b209a696d0b47
Cr-Commit-Position: refs/heads/master@{#409000}