Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7527)

Unified Diff: chrome/renderer/BUILD.gn

Issue 2198143002: Componentize spellcheck [3]: move renderer/ files to component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/renderer/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/BUILD.gn
diff --git a/chrome/renderer/BUILD.gn b/chrome/renderer/BUILD.gn
index bd82cadc0274a82c74a07d77a6eb1f1ef6c559c4..53cff96e8a2545cab4eb0ccad6dccdfae7b95ef9 100644
--- a/chrome/renderer/BUILD.gn
+++ b/chrome/renderer/BUILD.gn
@@ -152,19 +152,7 @@ static_library("renderer") {
"..")
}
if (enable_spellcheck) {
- sources +=
- rebase_path(gypi_values.chrome_renderer_spellchecker_sources, ".", "..")
- deps += [ "//components/spellcheck/common:common" ]
-
- if (!is_android) {
- deps += [ "//third_party/hunspell" ]
- }
- }
- if (!use_browser_spellchecker) {
- sources -= [
- "spellchecker/platform_spelling_engine.cc",
- "spellchecker/platform_spelling_engine.h",
- ]
+ deps += [ "//components/spellcheck/renderer:renderer" ]
}
if (enable_basic_printing || enable_print_preview) {
deps += [ "//printing" ]
@@ -180,12 +168,6 @@ static_library("renderer") {
if (is_win) {
deps += [ "//third_party/wtl" ]
}
- if (is_android) {
- sources -= [
- "spellchecker/hunspell_engine.cc",
- "spellchecker/hunspell_engine.h",
- ]
- }
if (is_chromeos) {
deps += [ "//chrome/renderer/leak_detector:leak_detector" ]
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/renderer/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698