Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3140)

Unified Diff: chrome/chrome_renderer.gypi

Issue 2198143002: Componentize spellcheck [3]: move renderer/ files to component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_renderer.gypi
diff --git a/chrome/chrome_renderer.gypi b/chrome/chrome_renderer.gypi
index c1c4dae15c41deb1448fc456c2844b62413f2fe0..1b03a2ba47ec1a58ea09db55e38075bfc0ee7c23 100644
--- a/chrome/chrome_renderer.gypi
+++ b/chrome/chrome_renderer.gypi
@@ -211,23 +211,6 @@
'renderer/safe_browsing/scorer.cc',
'renderer/safe_browsing/scorer.h',
],
- 'chrome_renderer_spellchecker_sources': [
- 'renderer/spellchecker/custom_dictionary_engine.cc',
- 'renderer/spellchecker/custom_dictionary_engine.h',
- 'renderer/spellchecker/hunspell_engine.cc',
- 'renderer/spellchecker/hunspell_engine.h',
- 'renderer/spellchecker/platform_spelling_engine.cc',
- 'renderer/spellchecker/platform_spelling_engine.h',
- 'renderer/spellchecker/spellcheck.cc',
- 'renderer/spellchecker/spellcheck.h',
- 'renderer/spellchecker/spellcheck_language.cc',
- 'renderer/spellchecker/spellcheck_language.h',
- 'renderer/spellchecker/spellcheck_provider.cc',
- 'renderer/spellchecker/spellcheck_provider.h',
- 'renderer/spellchecker/spellcheck_worditerator.cc',
- 'renderer/spellchecker/spellcheck_worditerator.h',
- 'renderer/spellchecker/spelling_engine.h',
- ],
'chrome_renderer_printing_sources': [
'renderer/printing/chrome_print_web_view_helper_delegate.cc',
'renderer/printing/chrome_print_web_view_helper_delegate.h',
@@ -357,28 +340,7 @@
],
}],
['enable_spellcheck==1', {
- 'sources': [
- '<@(chrome_renderer_spellchecker_sources)',
- ],
- 'conditions': [
- ['OS!="android"', {
- 'dependencies': [
- '../third_party/hunspell/hunspell.gyp:hunspell',
- ],
- }],
- ],
- }],
- ['use_browser_spellchecker==0', {
- 'sources!': [
- 'renderer/spellchecker/platform_spelling_engine.cc',
- 'renderer/spellchecker/platform_spelling_engine.h',
- ]
- }],
- ['OS=="android"', {
- 'sources!': [
- 'renderer/spellchecker/hunspell_engine.cc',
- 'renderer/spellchecker/hunspell_engine.h',
- ]
+ 'dependencies': [ '../components/components.gyp:spellcheck_renderer' ]
}],
['enable_basic_printing==1 or enable_print_preview==1', {
'dependencies': [
« no previous file with comments | « no previous file | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698