Fix --enable-logging after VS2013 switch

base/process/launch_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/process/launch.h"
 
 #include <fcntl.h>
 #include <io.h>
 #include <shellapi.h>
 #include <windows.h>
@@ skipping 45 matching lines @@
   // that case, we don't want to open CONOUT$, because its output
   // likely does not go anywhere.
   //
   // We don't use GetStdHandle() to check stdout/stderr here because
   // it can return dangling IDs of handles that were never inherited
   // by this process.  These IDs could have been reused by the time
   // this function is called.  The CRT checks the validity of
   // stdout/stderr on startup (before the handle IDs can be reused).
   // _fileno(stdout) will return -2 (_NO_CONSOLE_FILENO) if stdout was
   // invalid.
-  if (_fileno(stdout) >= 0 || _fileno(stderr) >= 0)
-    return;
+  if (_fileno(stdout) >= 0 || _fileno(stderr) >= 0) {
+    // _fileno was broken for SUBSYSTEM:WINDOWS from VS2010 to VS2012/2013.
+    // http://connect.microsoft.com/VisualStudio/feedback/details/785119/
+    // Confirm that the underlying HANDLE is valid before aborting.
+    intptr_t stdout_handle = _get_osfhandle(_fileno(stdout));

[Mark Seaborn, 2014/03/31 18:39:08]

Does intptr_t work on the MSVC toolchains that Chrome supports?  (I don't see
trybot runs for this change. :-) )  stdint.h used not to be available in MSVC.

[scottmg, 2014/03/31 18:46:13]

Assuming it works for the various compilers of base that aren't MSVC, it should
be ok, we only build with 2013 now. trybots started now anyway. :)

+    intptr_t stderr_handle = _get_osfhandle(_fileno(stderr));
+    if (stdout_handle >= 0 || stderr_handle >= 0)
+      return;
+  }
 
   if (!AttachConsole(ATTACH_PARENT_PROCESS)) {
     unsigned int result = GetLastError();
     // Was probably already attached.
     if (result == ERROR_ACCESS_DENIED)
       return;
     // Don't bother creating a new console for each child process if the
     // parent process is invalid (eg: crashed).
     if (result == ERROR_GEN_FAILURE)
       return;
@@ skipping 281 matching lines @@
   WaitForSingleObject(proc_info.process_handle(), INFINITE);
 
   return true;
 }
 
 void RaiseProcessToHighPriority() {
   SetPriorityClass(GetCurrentProcess(), HIGH_PRIORITY_CLASS);
 }
 
 }  // namespace base