Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2198113002: Reland of Fold compositing display items into contained drawings if the drawing is a singleton. (Closed)

Created:
4 years, 4 months ago by Xianzhu
Modified:
4 years, 4 months ago
Reviewers:
chrishtr
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Fold compositing display items into contained drawings if the drawing is a singleton. Original issue's description: > Fold compositing display items into contained drawings if the drawing is a singleton. > > BUG=628831 > > Committed: https://crrev.com/09f3b178cfb677eaaf91a282df0d898a041378cd > Cr-Commit-Position: refs/heads/master@{#408725} This reverts patchset #7 id:110001 of https://codereview.chromium.org/2186643002/ (46344c2a474c1599c6cbc44297a1b9afcae04bb6). Change on the original CL: - During under-invalidation checking, allow invalidated display items in cached subsequence as long as they are the same as the the cached display items. This is to support skipped-cache display items in a cached subsequence. - Added an under-invalidation checking test for compositing drawing folding in cached subsequence. Committed: https://crrev.com/b4169ff2158e3aaecb6c90dcd49452ae6191eeca Cr-Commit-Position: refs/heads/master@{#409004}

Patch Set 1 #

Patch Set 2 : Fix the issue and add an under-invalidation test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -11 lines) Patch
M third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp View 2 chunks +23 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/CompositingRecorder.cpp View 2 chunks +39 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 1 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp View 1 3 chunks +41 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Xianzhu
4 years, 4 months ago (2016-08-01 17:12:49 UTC) #3
chrishtr
lgtm
4 years, 4 months ago (2016-08-01 17:22:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198113002/20001
4 years, 4 months ago (2016-08-01 17:22:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-01 18:40:47 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 18:43:01 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4169ff2158e3aaecb6c90dcd49452ae6191eeca
Cr-Commit-Position: refs/heads/master@{#409004}

Powered by Google App Engine
This is Rietveld 408576698