Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2198083002: Fix flaky testRequestFinishedListenerFailedRequest (Closed)

Created:
4 years, 4 months ago by mgersh
Modified:
4 years, 4 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky testRequestFinishedListenerFailedRequest The time reported can occasionally be 0. BUG=632925 Committed: https://crrev.com/451b6e4a2fd610565ed0102894b9975472ed2414 Cr-Commit-Position: refs/heads/master@{#408975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedListenerTest.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mgersh
PTAL
4 years, 4 months ago (2016-08-01 15:24:29 UTC) #2
xunjieli
lgtm
4 years, 4 months ago (2016-08-01 15:45:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198083002/1
4 years, 4 months ago (2016-08-01 15:47:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 16:28:30 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 16:29:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/451b6e4a2fd610565ed0102894b9975472ed2414
Cr-Commit-Position: refs/heads/master@{#408975}

Powered by Google App Engine
This is Rietveld 408576698