Default fake gamma to sRGB.

Default fake gamma to sRGB.

No one appears to be using the default 2.2.
This makes SK_GAMMA_SRGB the default / a no-op, which seems more realistic.

Chrome's explicitly setting SK_GAMMA_EXPONENT or SK_GAMMA_SRGB.
We set Android platform explicitly to 1.4.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198073002

Committed: https://skia.googlesource.com/skia/+/8d7f5c3f29b1ce9caaeed0e80f15eaedcf412c25

[mtklein_C, 2016-08-01 15:07:34]

Description was changed from

==========
Default fake gamma to sRGB.

No one appears to be using the default 2.2.
This makes SK_GAMMA_SRGB the default / a no-op, which seems more realistic.

Chrome's explicitly setting SK_GAMMA_EXPONENT or SK_GAMMA_SRGB.
We set Android platform explicitly to 1.4.


BUG=skia:
==========

to

==========
Default fake gamma to sRGB.

No one appears to be using the default 2.2.
This makes SK_GAMMA_SRGB the default / a no-op, which seems more realistic.

Chrome's explicitly setting SK_GAMMA_EXPONENT or SK_GAMMA_SRGB.
We set Android platform explicitly to 1.4.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198073002
==========

[mtklein_C, 2016-08-01 15:11:20]

mtklein@chromium.org changed reviewers:
+ bungeman@google.com, reed@google.com

[mtklein_C, 2016-08-01 15:11:20]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2016-08-01 15:11:21]

This is not pressing.  I just noticed this fake-gamma configuration was a bit
more complex than actually used.

[commit-bot: I haz the power, 2016-08-01 15:11:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 15:12:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 15:13:00]

Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[bungeman-skia, 2016-08-01 15:17:22]

lgtm

https://codereview.chromium.org/2198073002/diff/20001/include/core/SkPostConf...
File include/core/SkPostConfig.h (right):

https://codereview.chromium.org/2198073002/diff/20001/include/core/SkPostConf...
include/core/SkPostConfig.h:322: #define SK_GAMMA_EXPONENT (0.0f)  // SRGB
nit: the hash is indented, while the rest of the file doesn't indent the hash.

[mtklein_C, 2016-08-01 15:18:16]

On 2016/08/01 at 15:17:22, bungeman wrote:
> lgtm
> 
>
https://codereview.chromium.org/2198073002/diff/20001/include/core/SkPostConf...
> File include/core/SkPostConfig.h (right):
> 
>
https://codereview.chromium.org/2198073002/diff/20001/include/core/SkPostConf...
> include/core/SkPostConfig.h:322: #define SK_GAMMA_EXPONENT (0.0f)  // SRGB
> nit: the hash is indented, while the rest of the file doesn't indent the hash.

Hmm.  I think this way reads better.  What do you think?

[reed1, 2016-08-01 15:18:43]

lgtm

[mtklein_C, 2016-08-01 16:20:51]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-08-01 16:21:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 16:22:15]

Description was changed from

==========
Default fake gamma to sRGB.

No one appears to be using the default 2.2.
This makes SK_GAMMA_SRGB the default / a no-op, which seems more realistic.

Chrome's explicitly setting SK_GAMMA_EXPONENT or SK_GAMMA_SRGB.
We set Android platform explicitly to 1.4.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198073002
==========

to

==========
Default fake gamma to sRGB.

No one appears to be using the default 2.2.
This makes SK_GAMMA_SRGB the default / a no-op, which seems more realistic.

Chrome's explicitly setting SK_GAMMA_EXPONENT or SK_GAMMA_SRGB.
We set Android platform explicitly to 1.4.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198073002

Committed:
https://skia.googlesource.com/skia/+/8d7f5c3f29b1ce9caaeed0e80f15eaedcf412c25
==========

[commit-bot: I haz the power, 2016-08-01 16:22:16]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8d7f5c3f29b1ce9caaeed0e80f15eaedcf412c25