Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: test/cctest/test-parsing.cc

Issue 2198043002: Add a mode to completely deserialize scope chains (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/parser.cc ('k') | test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index 656458962a42094ecb7ca2a2985f7046369a6d7f..cdfb77d654b96fff0b38732c569a17593c5dd7e5 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -3396,8 +3396,9 @@ TEST(SerializationOfMaybeAssignmentFlag) {
CHECK(str->IsInternalizedString());
i::Scope* script_scope =
new (&zone) i::Scope(&zone, nullptr, i::SCRIPT_SCOPE);
- i::Scope* s = i::Scope::DeserializeScopeChain(isolate, &zone, context,
- script_scope, &avf);
+ i::Scope* s = i::Scope::DeserializeScopeChain(
+ isolate, &zone, context, script_scope, &avf,
+ i::Scope::DeserializationMode::kKeepScopeInfo);
CHECK(s != script_scope);
CHECK(name != NULL);
@@ -3443,8 +3444,9 @@ TEST(IfArgumentsArrayAccessedThenParametersMaybeAssigned) {
i::Scope* script_scope =
new (&zone) i::Scope(&zone, nullptr, i::SCRIPT_SCOPE);
- i::Scope* s = i::Scope::DeserializeScopeChain(isolate, &zone, context,
- script_scope, &avf);
+ i::Scope* s = i::Scope::DeserializeScopeChain(
+ isolate, &zone, context, script_scope, &avf,
+ i::Scope::DeserializationMode::kKeepScopeInfo);
CHECK(s != script_scope);
const i::AstRawString* name_x = avf.GetOneByteString("x");
« no previous file with comments | « src/parsing/parser.cc ('k') | test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698