Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2198023002: Fix GN bootstrap (Closed)

Created:
4 years, 4 months ago by Paweł Hajdan Jr.
Modified:
4 years, 4 months ago
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/gn/bootstrap/bootstrap.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Paweł Hajdan Jr.
4 years, 4 months ago (2016-08-01 13:23:45 UTC) #2
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-01 14:50:14 UTC) #4
Sergiy Byelozyorov
not sure why I am on this CL
4 years, 4 months ago (2016-08-01 15:24:17 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c0854701a20853eb16cf4aa7a9584eefa000d559 Cr-Commit-Position: refs/heads/master@{#409158}
4 years, 4 months ago (2016-08-02 08:58:20 UTC) #7
Paweł Hajdan Jr.
4 years, 4 months ago (2016-08-02 08:59:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c0854701a20853eb16cf4aa7a9584eefa000d559 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698