Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2197973002: Move ContextSlotCache to its own file (Closed)

Created:
4 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
Reviewers:
Toon Verwaest, marja
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move ContextSlotCache to its own file Also remove unnecessary includes of scopeinfo.h all over the place R=marja@chromium.org TBR=verwaest@chromium.org BUG= Committed: https://crrev.com/95cae2eb3578171e4ea49f18470b48bdd96e5f55 Cr-Commit-Position: refs/heads/master@{#38204}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -191 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + src/ast/context-slot-cache.h View 2 chunks +4 lines, -5 lines 0 comments Download
A src/ast/context-slot-cache.cc View 1 chunk +91 lines, -0 lines 0 comments Download
M src/ast/scopeinfo.h View 1 chunk +0 lines, -96 lines 1 comment Download
M src/ast/scopeinfo.cc View 2 chunks +1 line, -76 lines 0 comments Download
M src/ast/scopes.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/contexts.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/debug/liveedit.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/frames.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/profiler/profile-generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime-profiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-08-01 10:59:05 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2197973002/diff/1/src/ast/scopeinfo.h File src/ast/scopeinfo.h (right): https://codereview.chromium.org/2197973002/diff/1/src/ast/scopeinfo.h#newcode13 src/ast/scopeinfo.h:13: namespace internal { I kept this file around, because ...
4 years, 4 months ago (2016-08-01 11:00:51 UTC) #4
marja
rubberstamp lgtm
4 years, 4 months ago (2016-08-01 11:04:59 UTC) #5
jochen (gone - plz use gerrit)
TBR toon for include updates
4 years, 4 months ago (2016-08-01 11:28:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197973002/1
4 years, 4 months ago (2016-08-01 11:28:44 UTC) #12
Toon Verwaest
lgtm
4 years, 4 months ago (2016-08-01 11:29:05 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 11:30:53 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 11:33:52 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/95cae2eb3578171e4ea49f18470b48bdd96e5f55
Cr-Commit-Position: refs/heads/master@{#38204}

Powered by Google App Engine
This is Rietveld 408576698