Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2197913002: [turbofan] Fix various bailout points for AstGraphBuilder. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix various bailout points for AstGraphBuilder. This introduces a bunch of new tests that test various aspects of accessor inlining in TurboFan (without the actual inlining), and does the appropriate fixes to the AstGraphBuilder. The actual inlining CL will land separately (so we don't need to revert the tests and fixes if the accessor CL has to be reverted). R=jarin@chromium.org Committed: https://crrev.com/986b04a62a5e3617f7c951ff91b83bcd1daa6f85 Cr-Commit-Position: refs/heads/master@{#38191}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -46 lines) Patch
M src/compiler/ast-graph-builder.cc View 8 chunks +12 lines, -18 lines 0 comments Download
A + test/mjsunit/compiler/accessor-exceptions1.js View 1 1 chunk +12 lines, -8 lines 0 comments Download
A + test/mjsunit/compiler/accessor-exceptions2.js View 1 1 chunk +12 lines, -8 lines 0 comments Download
A test/mjsunit/compiler/deopt-accessors1.js View 1 chunk +28 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/deopt-accessors2.js View 1 chunk +28 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/deopt-accessors3.js View 1 chunk +29 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/deopt-accessors4.js View 1 chunk +29 lines, -0 lines 0 comments Download
A + test/mjsunit/compiler/deopt-accessors5.js View 1 chunk +14 lines, -6 lines 0 comments Download
A + test/mjsunit/compiler/deopt-accessors6.js View 1 chunk +15 lines, -6 lines 0 comments Download
A test/mjsunit/compiler/deopt-accessors7.js View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-01 05:51:07 UTC) #1
Jarin
lgtm with a small request. https://codereview.chromium.org/2197913002/diff/1/test/mjsunit/compiler/accessor-exceptions1.js File test/mjsunit/compiler/accessor-exceptions1.js (right): https://codereview.chromium.org/2197913002/diff/1/test/mjsunit/compiler/accessor-exceptions1.js#newcode13 test/mjsunit/compiler/accessor-exceptions1.js:13: try { o.x; } ...
4 years, 4 months ago (2016-08-01 05:55:26 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/2197913002/diff/1/test/mjsunit/compiler/accessor-exceptions1.js File test/mjsunit/compiler/accessor-exceptions1.js (right): https://codereview.chromium.org/2197913002/diff/1/test/mjsunit/compiler/accessor-exceptions1.js#newcode13 test/mjsunit/compiler/accessor-exceptions1.js:13: try { o.x; } catch (e) { } On ...
4 years, 4 months ago (2016-08-01 05:55:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2197913002/20001
4 years, 4 months ago (2016-08-01 05:56:08 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-01 06:17:28 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 06:18:56 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/986b04a62a5e3617f7c951ff91b83bcd1daa6f85
Cr-Commit-Position: refs/heads/master@{#38191}

Powered by Google App Engine
This is Rietveld 408576698