Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3363)

Unified Diff: ash/wm/base_layout_manager.h

Issue 21979005: Make sure that 30%of restored window is always visible. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: AdjustWindowBoundsWhenAdded Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/base_layout_manager.h
diff --git a/ash/wm/base_layout_manager.h b/ash/wm/base_layout_manager.h
index 7fe25e5fe678418612880e32d2fe1d1e6422f110..977f0885f9de5ac24e4997810ec1bda976e4345e 100644
--- a/ash/wm/base_layout_manager.h
+++ b/ash/wm/base_layout_manager.h
@@ -77,27 +77,28 @@ class ASH_EXPORT BaseLayoutManager
protected:
enum AdjustWindowReason {
- ADJUST_WINDOW_SCREEN_SIZE_CHANGED,
- ADJUST_WINDOW_DISPLAY_INSETS_CHANGED,
- ADJUST_WINDOW_WINDOW_ADDED
+ ADJUST_WINDOW_DISPLAY_SIZE_CHANGED,
+ ADJUST_WINDOW_WORK_AREA_INSETS_CHANGED,
};
// Invoked from OnWindowPropertyChanged() if |kShowStateKey| changes.
virtual void ShowStateChanged(aura::Window* window,
ui::WindowShowState last_show_state);
- // Adjusts the window sizes when the screen changes its size or its
- // work area insets. If this is called for a screen size change (i.e. |reason|
+ // Adjusts the window's bounds when the display area changes for given
+ // window. This happens when the display size, work area insets or
+ // the display on which the window exists has changd.
James Cook 2013/08/07 00:36:32 changd -> changed
oshima 2013/08/07 16:56:45 Done.
+ // If this is called for a display size change (i.e. |reason|
// is ADJUST_WINDOW_SCREEN_SIZE_CHANGED), the non-maximized/non-fullscreen
James Cook 2013/08/07 00:36:32 ADJUST_WINDOW_DISPLAY_SIZE_CHANGED ?
oshima 2013/08/07 16:56:45 Done.
// windows are readjusted to make sure the window is completely within the
// display region. Otherwise, it makes sure at least some parts of the window
// is on display.
- virtual void AdjustWindowSizesForScreenChange(AdjustWindowReason reason);
+ virtual void AdjustWindowsBoundsForWorkAreaChange(AdjustWindowReason reason);
James Cook 2013/08/07 00:36:32 This might be clearer as AdjustAllWindowBoundsForW
oshima 2013/08/07 16:56:45 Agreed. Done.
// Adjusts the sizes of the specific window in respond to a screen change or
// display-area size change.
- virtual void AdjustWindowSizeForScreenChange(aura::Window* window,
- AdjustWindowReason reason);
+ virtual void AdjustWindowBoundsForWorkAreaChange(aura::Window* window,
+ AdjustWindowReason reason);
aura::RootWindow* root_window() { return root_window_; }

Powered by Google App Engine
This is Rietveld 408576698