DevTools: Take into account links from root to user global objects when building heap snapshot.

DevTools: Take into account links from root to user global objects when building heap snapshot.

Traverse the links during building postorder iterator as well as the dominator tree.

Committed: https://crrev.com/98792629df48f18611b8cc73cf49d4f103bb3b19
Cr-Commit-Position: refs/heads/master@{#408835}

[alph, 2016-07-29 23:22:28]

alph@chromium.org changed reviewers:
+ caseq@chromium.org

[alph, 2016-07-29 23:24:59]

Description was changed from

==========
DevTools: Take links from root to user global objects when building heap
snapshot.

Traverse the links during building postorder iterator as well as the dominator
tree.
==========

to

==========
DevTools: Take into account links from root to user global objects when building
heap snapshot.

Traverse the links during building postorder iterator as well as the dominator
tree.
==========

[caseq, 2016-07-30 00:10:28]

lgtm

https://codereview.chromium.org/2197853002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js
(right):

https://codereview.chromium.org/2197853002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js:1602:
* @param {number} nodeIndex
nit: blank line above.

https://codereview.chromium.org/2197853002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js:1609:
var edgeWeakType = this._edgeWeakType;
let's inline both of the above?

[alph, 2016-07-30 00:15:54]

https://codereview.chromium.org/2197853002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js
(right):

https://codereview.chromium.org/2197853002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js:1602:
* @param {number} nodeIndex
On 2016/07/30 00:10:28, caseq wrote:
> nit: blank line above.

Done.

https://codereview.chromium.org/2197853002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js:1609:
var edgeWeakType = this._edgeWeakType;
On 2016/07/30 00:10:28, caseq wrote:
> let's inline both of the above?

Done.

[alph, 2016-07-30 00:16:28]

The CQ bit was checked by alph@chromium.org

[alph, 2016-07-30 00:16:28]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2197853002/#ps20001
(title: "addressing comments.")

[commit-bot: I haz the power, 2016-07-30 00:16:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 01:33:40]

Description was changed from

==========
DevTools: Take into account links from root to user global objects when building
heap snapshot.

Traverse the links during building postorder iterator as well as the dominator
tree.
==========

to

==========
DevTools: Take into account links from root to user global objects when building
heap snapshot.

Traverse the links during building postorder iterator as well as the dominator
tree.
==========

[commit-bot: I haz the power, 2016-07-30 01:33:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-30 01:35:27]

Description was changed from

==========
DevTools: Take into account links from root to user global objects when building
heap snapshot.

Traverse the links during building postorder iterator as well as the dominator
tree.
==========

to

==========
DevTools: Take into account links from root to user global objects when building
heap snapshot.

Traverse the links during building postorder iterator as well as the dominator
tree.

Committed: https://crrev.com/98792629df48f18611b8cc73cf49d4f103bb3b19
Cr-Commit-Position: refs/heads/master@{#408835}
==========

[commit-bot: I haz the power, 2016-07-30 01:35:28]

Patchset 2 (id:??) landed as
https://crrev.com/98792629df48f18611b8cc73cf49d4f103bb3b19
Cr-Commit-Position: refs/heads/master@{#408835}