Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: fpdfsdk/fsdk_baseform.cpp

Issue 2197793002: Watch for destruction of widget during callback (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: asserts, comments, braces Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | fpdfsdk/include/fsdk_baseform.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "fpdfsdk/include/fsdk_baseform.h" 7 #include "fpdfsdk/include/fsdk_baseform.h"
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <map> 10 #include <map>
11 #include <memory> 11 #include <memory>
12 #include <vector> 12 #include <vector>
13 13
14 #include "core/fpdfapi/fpdf_page/include/cpdf_page.h" 14 #include "core/fpdfapi/fpdf_page/include/cpdf_page.h"
15 #include "core/fpdfapi/fpdf_parser/include/cfdf_document.h" 15 #include "core/fpdfapi/fpdf_parser/include/cfdf_document.h"
16 #include "core/fpdfapi/fpdf_parser/include/cpdf_array.h" 16 #include "core/fpdfapi/fpdf_parser/include/cpdf_array.h"
17 #include "core/fpdfapi/fpdf_parser/include/cpdf_document.h" 17 #include "core/fpdfapi/fpdf_parser/include/cpdf_document.h"
18 #include "core/fpdfapi/fpdf_parser/include/cpdf_stream.h" 18 #include "core/fpdfapi/fpdf_parser/include/cpdf_stream.h"
19 #include "core/fxge/include/fx_ge.h" 19 #include "core/fxge/include/fx_ge.h"
20 #include "fpdfsdk/formfiller/cffl_formfiller.h" 20 #include "fpdfsdk/formfiller/cffl_formfiller.h"
21 #include "fpdfsdk/fxedit/include/fxet_edit.h" 21 #include "fpdfsdk/fxedit/include/fxet_edit.h"
22 #include "fpdfsdk/include/fsdk_actionhandler.h" 22 #include "fpdfsdk/include/fsdk_actionhandler.h"
23 #include "fpdfsdk/include/fsdk_baseannot.h" 23 #include "fpdfsdk/include/fsdk_baseannot.h"
24 #include "fpdfsdk/include/fsdk_define.h" 24 #include "fpdfsdk/include/fsdk_define.h"
25 #include "fpdfsdk/include/fsdk_mgr.h" 25 #include "fpdfsdk/include/fsdk_mgr.h"
26 #include "fpdfsdk/javascript/ijs_context.h" 26 #include "fpdfsdk/javascript/ijs_context.h"
27 #include "fpdfsdk/javascript/ijs_runtime.h" 27 #include "fpdfsdk/javascript/ijs_runtime.h"
28 #include "fpdfsdk/pdfwindow/PWL_Utils.h" 28 #include "fpdfsdk/pdfwindow/PWL_Utils.h"
29 #include "third_party/base/stl_util.h"
29 30
30 #ifdef PDF_ENABLE_XFA 31 #ifdef PDF_ENABLE_XFA
31 #include "fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h" 32 #include "fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h"
32 #include "fpdfsdk/fpdfxfa/include/fpdfxfa_util.h" 33 #include "fpdfsdk/fpdfxfa/include/fpdfxfa_util.h"
33 #include "xfa/fxfa/include/cxfa_eventparam.h" 34 #include "xfa/fxfa/include/cxfa_eventparam.h"
34 #include "xfa/fxfa/include/xfa_ffdocview.h" 35 #include "xfa/fxfa/include/xfa_ffdocview.h"
35 #include "xfa/fxfa/include/xfa_ffwidget.h" 36 #include "xfa/fxfa/include/xfa_ffwidget.h"
36 #include "xfa/fxfa/include/xfa_ffwidgethandler.h" 37 #include "xfa/fxfa/include/xfa_ffwidgethandler.h"
37 #endif // PDF_ENABLE_XFA 38 #endif // PDF_ENABLE_XFA
38 39
39 PDFSDK_FieldAction::PDFSDK_FieldAction() 40 PDFSDK_FieldAction::PDFSDK_FieldAction()
40 : bModifier(FALSE), 41 : bModifier(FALSE),
41 bShift(FALSE), 42 bShift(FALSE),
42 nCommitKey(0), 43 nCommitKey(0),
43 bKeyDown(FALSE), 44 bKeyDown(FALSE),
44 nSelEnd(0), 45 nSelEnd(0),
45 nSelStart(0), 46 nSelStart(0),
46 bWillCommit(FALSE), 47 bWillCommit(FALSE),
47 bFieldFull(FALSE), 48 bFieldFull(FALSE),
48 bRC(TRUE) {} 49 bRC(TRUE) {}
49 50
51 CPDFSDK_Widget::Observer::Observer(CPDFSDK_Widget** pWatchedPtr)
52 : m_pWatchedPtr(pWatchedPtr) {
53 (*m_pWatchedPtr)->AddObserver(this);
54 }
55
56 CPDFSDK_Widget::Observer::~Observer() {
57 if (m_pWatchedPtr)
58 (*m_pWatchedPtr)->RemoveObserver(this);
59 }
60
61 void CPDFSDK_Widget::Observer::OnWidgetDestroyed() {
62 ASSERT(m_pWatchedPtr);
63 *m_pWatchedPtr = nullptr;
64 m_pWatchedPtr = nullptr;
65 }
66
50 CPDFSDK_Widget::CPDFSDK_Widget(CPDF_Annot* pAnnot, 67 CPDFSDK_Widget::CPDFSDK_Widget(CPDF_Annot* pAnnot,
51 CPDFSDK_PageView* pPageView, 68 CPDFSDK_PageView* pPageView,
52 CPDFSDK_InterForm* pInterForm) 69 CPDFSDK_InterForm* pInterForm)
53 : CPDFSDK_BAAnnot(pAnnot, pPageView), 70 : CPDFSDK_BAAnnot(pAnnot, pPageView),
54 m_pInterForm(pInterForm), 71 m_pInterForm(pInterForm),
55 m_nAppAge(0), 72 m_nAppAge(0),
56 m_nValueAge(0) 73 m_nValueAge(0)
57 #ifdef PDF_ENABLE_XFA 74 #ifdef PDF_ENABLE_XFA
58 , 75 ,
59 m_hMixXFAWidget(nullptr), 76 m_hMixXFAWidget(nullptr),
60 m_pWidgetHandler(nullptr) 77 m_pWidgetHandler(nullptr)
61 #endif // PDF_ENABLE_XFA 78 #endif // PDF_ENABLE_XFA
62 { 79 {
63 } 80 }
64 81
65 CPDFSDK_Widget::~CPDFSDK_Widget() {} 82 CPDFSDK_Widget::~CPDFSDK_Widget() {
83 for (auto* pObserver : m_Observers)
84 pObserver->OnWidgetDestroyed();
85 }
86
87 void CPDFSDK_Widget::AddObserver(Observer* pObserver) {
88 ASSERT(!pdfium::ContainsKey(m_Observers, pObserver));
89 m_Observers.insert(pObserver);
90 }
91
92 void CPDFSDK_Widget::RemoveObserver(Observer* pObserver) {
93 ASSERT(pdfium::ContainsKey(m_Observers, pObserver));
94 m_Observers.erase(pObserver);
95 }
66 96
67 #ifdef PDF_ENABLE_XFA 97 #ifdef PDF_ENABLE_XFA
68 CXFA_FFWidget* CPDFSDK_Widget::GetMixXFAWidget() const { 98 CXFA_FFWidget* CPDFSDK_Widget::GetMixXFAWidget() const {
69 CPDFSDK_Document* pSDKDoc = m_pPageView->GetSDKDocument(); 99 CPDFSDK_Document* pSDKDoc = m_pPageView->GetSDKDocument();
70 CPDFXFA_Document* pDoc = pSDKDoc->GetXFADocument(); 100 CPDFXFA_Document* pDoc = pSDKDoc->GetXFADocument();
71 if (pDoc->GetDocType() == DOCTYPE_STATIC_XFA) { 101 if (pDoc->GetDocType() == DOCTYPE_STATIC_XFA) {
72 if (!m_hMixXFAWidget) { 102 if (!m_hMixXFAWidget) {
73 if (CXFA_FFDocView* pDocView = pDoc->GetXFADocView()) { 103 if (CXFA_FFDocView* pDocView = pDoc->GetXFADocView()) {
74 CFX_WideString sName; 104 CFX_WideString sName;
75 if (GetFieldType() == FIELDTYPE_RADIOBUTTON) { 105 if (GetFieldType() == FIELDTYPE_RADIOBUTTON) {
(...skipping 2751 matching lines...) Expand 10 before | Expand all | Expand 10 after
2827 break; 2857 break;
2828 } 2858 }
2829 } 2859 }
2830 } 2860 }
2831 2861
2832 CFX_FloatRect CBA_AnnotIterator::GetAnnotRect(const CPDFSDK_Annot* pAnnot) { 2862 CFX_FloatRect CBA_AnnotIterator::GetAnnotRect(const CPDFSDK_Annot* pAnnot) {
2833 CFX_FloatRect rcAnnot; 2863 CFX_FloatRect rcAnnot;
2834 pAnnot->GetPDFAnnot()->GetRect(rcAnnot); 2864 pAnnot->GetPDFAnnot()->GetRect(rcAnnot);
2835 return rcAnnot; 2865 return rcAnnot;
2836 } 2866 }
OLDNEW
« no previous file with comments | « no previous file | fpdfsdk/include/fsdk_baseform.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698