Fix bug with blank pages during navigation

Fix bug with blank pages during navigation

This bug started after r408172.  In some situations when navigating, the
SetNeedsBeginFrame messages that is sent from the
CompositorExternalBeginFrameSource to the RenderWidgetHostView, but is
received by the RenderWidgetHostImpl while the RenderViewHost is swapped
out and before it has swapped back in.  In these cases, if this message
is dropped, the renderer will never tick new frames and the tab will
freeze.  This appears to be racy, as the renderer finds out that it is
visible and sends this message before the view host is swapped in.

To fix this race, always allow the SetNeedsBeginFrame message to be
received while being swapped out so that the RenderWidgetHostView can be
in the correct state when it is swapped in.

R=sievers@chromium.org
BUG=632276
Committed: https://crrev.com/fae0fb34ab73f12a8be3493f0ec06dbbb32c7b20
Cr-Commit-Position: refs/heads/master@{#408787}

[no sievers, 2016-07-29 21:04:38]

lgtm

[enne (OOO), 2016-07-29 21:04:56]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2016-07-29 21:05:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 21:12:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 21:12:27]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[enne (OOO), 2016-07-29 21:16:29]

enne@chromium.org changed reviewers:
+ kenrb@chromium.org

[enne (OOO), 2016-07-29 21:16:44]

+kenrb for content/common/*messages OWNERS

[kenrb, 2016-07-29 21:48:02]

ipc lgtm

[enne (OOO), 2016-07-29 21:54:11]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2016-07-29 21:54:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 22:33:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-29 22:35:27]

Description was changed from

==========
Fix bug with blank pages during navigation

This bug started after r408172.  In some situations when navigating, the
SetNeedsBeginFrame messages that is sent from the
CompositorExternalBeginFrameSource to the RenderWidgetHostView, but is
received by the RenderWidgetHostImpl while the RenderViewHost is swapped
out and before it has swapped back in.  In these cases, if this message
is dropped, the renderer will never tick new frames and the tab will
freeze.  This appears to be racy, as the renderer finds out that it is
visible and sends this message before the view host is swapped in.

To fix this race, always allow the SetNeedsBeginFrame message to be
received while being swapped out so that the RenderWidgetHostView can be
in the correct state when it is swapped in.

R=sievers@chromium.org
BUG=632276
==========

to

==========
Fix bug with blank pages during navigation

This bug started after r408172.  In some situations when navigating, the
SetNeedsBeginFrame messages that is sent from the
CompositorExternalBeginFrameSource to the RenderWidgetHostView, but is
received by the RenderWidgetHostImpl while the RenderViewHost is swapped
out and before it has swapped back in.  In these cases, if this message
is dropped, the renderer will never tick new frames and the tab will
freeze.  This appears to be racy, as the renderer finds out that it is
visible and sends this message before the view host is swapped in.

To fix this race, always allow the SetNeedsBeginFrame message to be
received while being swapped out so that the RenderWidgetHostView can be
in the correct state when it is swapped in.

R=sievers@chromium.org
BUG=632276

Committed: https://crrev.com/fae0fb34ab73f12a8be3493f0ec06dbbb32c7b20
Cr-Commit-Position: refs/heads/master@{#408787}
==========

[commit-bot: I haz the power, 2016-07-29 22:35:29]

Patchset 1 (id:??) landed as
https://crrev.com/fae0fb34ab73f12a8be3493f0ec06dbbb32c7b20
Cr-Commit-Position: refs/heads/master@{#408787}

[tapted, 2016-08-01 01:34:52]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2200593002/ by tapted@chromium.org.

The reason for reverting is: Suspected for widespread NaCl plugin failures on
waterfall since
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui...

Crashes with "Actual: "Plugin crashed. 'NaCl module crashed"

It wasn't r408782, so I think it's gotta be this or r408781..