Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2197773004: Fuchsia: Paralellize VM test wrapper. Update statuses for Fuchsia update (Closed)

Created:
4 years, 4 months ago by zra
Modified:
4 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia: Paralellize VM test wrapper. Update statuses for Fuchsia update R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/31c98f0191704cd813f6e63c5b3f7a5092320cc7

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -37 lines) Patch
M runtime/bin/run_vm_tests_fuchsia.cc View 1 10 chunks +119 lines, -35 lines 0 comments Download
M runtime/vm/os_fuchsia.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 4 months ago (2016-07-29 20:26:18 UTC) #2
siva
lgtm https://codereview.chromium.org/2197773004/diff/1/runtime/bin/run_vm_tests_fuchsia.cc File runtime/bin/run_vm_tests_fuchsia.cc (right): https://codereview.chromium.org/2197773004/diff/1/runtime/bin/run_vm_tests_fuchsia.cc#newcode306 runtime/bin/run_vm_tests_fuchsia.cc:306: ASSERT(test_list_index == lines_count); https://codereview.chromium.org/2197773004/diff/1/runtime/bin/run_vm_tests_fuchsia.cc#newcode311 runtime/bin/run_vm_tests_fuchsia.cc:311: free(test_list); pthread_mutex_destroy(&args_mutex); for ...
4 years, 4 months ago (2016-07-29 20:58:12 UTC) #3
zra
https://codereview.chromium.org/2197773004/diff/1/runtime/bin/run_vm_tests_fuchsia.cc File runtime/bin/run_vm_tests_fuchsia.cc (right): https://codereview.chromium.org/2197773004/diff/1/runtime/bin/run_vm_tests_fuchsia.cc#newcode306 runtime/bin/run_vm_tests_fuchsia.cc:306: On 2016/07/29 20:58:12, siva wrote: > ASSERT(test_list_index == lines_count); ...
4 years, 4 months ago (2016-07-29 21:20:16 UTC) #4
zra
4 years, 4 months ago (2016-07-29 21:20:50 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
31c98f0191704cd813f6e63c5b3f7a5092320cc7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698