ash/common/wm/overview/window_grid.cc - Issue 2197773002: [ash-md] Properly scales windows with transient parents in overview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/wm/overview/window_grid.cc

Issue 2197773002: [ash-md] Properly scales windows with transient parents in overview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [ash-md] Disables rounded corners by default in overview mode (nits) Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/common/wm/overview/window_grid.cc

diff --git a/ash/common/wm/overview/window_grid.cc b/ash/common/wm/overview/window_grid.cc

index 9652e5deefc6fb2d85b274d0a482d19c0639dedc..76e44b8629279477400d1e8e0c5585ac632fe6f2 100644

--- a/ash/common/wm/overview/window_grid.cc

+++ b/ash/common/wm/overview/window_grid.cc

@@ -18,7 +18,6 @@

#include "ash/common/wm/overview/cleanup_animation_observer.h"

#include "ash/common/wm/overview/scoped_overview_animation_settings.h"

#include "ash/common/wm/overview/scoped_overview_animation_settings_factory.h"

-#include "ash/common/wm/overview/scoped_transform_overview_window.h"

#include "ash/common/wm/overview/window_selector.h"

#include "ash/common/wm/overview/window_selector_delegate.h"

#include "ash/common/wm/overview/window_selector_item.h"

@@ -1012,7 +1011,7 @@ bool WindowGrid::FitWindowRectsInBounds(const gfx::Rect& bounds,

const gfx::Size item_size(0, height);

size_t i = 0;

for (auto* window : window_list_) {

- const gfx::Rect target_bounds = window->GetWindow()->GetTargetBounds();

+ const gfx::Rect target_bounds = window->GetTargetBoundsInScreen();

const int width =

std::max(1, gfx::ToFlooredInt(target_bounds.width() *

window->GetItemScale(item_size)) +

« no previous file with comments | « ash/common/wm/overview/scoped_transform_overview_window.cc ('k') | ash/common/wm/overview/window_selector_item.h » ('j') | no next file with comments »