ash/common/wm/overview/window_selector_item.h - Issue 2197773002: [ash-md] Properly scales windows with transient parents in overview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/wm/overview/window_selector_item.h

Issue 2197773002: [ash-md] Properly scales windows with transient parents in overview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/common/wm/overview/scoped_transform_overview_window.cc ('K') | « ash/common/wm/overview/window_grid.cc ('k') | ash/common/wm/overview/window_selector_item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/common/wm/overview/window_selector_item.h

diff --git a/ash/common/wm/overview/window_selector_item.h b/ash/common/wm/overview/window_selector_item.h

index f533a4abe881aff7a97cc3cef12cc49d59b4fbaa..702517a4c2a7f001c236acabdc8a28295d1586f3 100644

--- a/ash/common/wm/overview/window_selector_item.h

+++ b/ash/common/wm/overview/window_selector_item.h

@@ -84,6 +84,9 @@ class ASH_EXPORT WindowSelectorItem : public views::ButtonListener,

// returns the scale that allows the item to fully fit within |size|.

float GetItemScale(const gfx::Size& size);

+ // Returns the original target bounds of all transformed windows.

tdanderson 2016/07/29 20:20:02 nit: explain in a bit more detail what you mean by

varkha 2016/07/29 20:45:12 Done.

+ gfx::Rect GetTargetBoundsInScreen() const;

// Sets the bounds of this window selector item to |target_bounds| in the

// |root_window_| root window. The bounds change will be animated as specified

// by |animation_type|.