components/arc/metrics/arc_metrics_service.cc - Issue 2197753002: Move OomKillsMonitor from a single-threaded SequencedWorkerPool to a non-joinable thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/metrics/arc_metrics_service.cc

Issue 2197753002: Move OomKillsMonitor from a single-threaded SequencedWorkerPool to a non-joinable thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a0_b1_nonjoinable_thread

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/arc/metrics/arc_metrics_service.h ('k') | components/arc/metrics/oom_kills_monitor.h » ('j') | components/arc/metrics/oom_kills_monitor.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/arc/metrics/arc_metrics_service.cc

diff --git a/components/arc/metrics/arc_metrics_service.cc b/components/arc/metrics/arc_metrics_service.cc

index 38e59d7879aa9a34a6a423ce92a79c477616808c..5368a2ce3480e163a3a284612329cbe1307fa810 100644

--- a/components/arc/metrics/arc_metrics_service.cc

+++ b/components/arc/metrics/arc_metrics_service.cc

@@ -31,7 +31,7 @@ ArcMetricsService::ArcMetricsService(ArcBridgeService* bridge_service)

weak_ptr_factory_(this) {

arc_bridge_service()->metrics()->AddObserver(this);

arc_bridge_service()->process()->AddObserver(&process_observer_);

- oom_kills_monitor_.Start();

+ oom_kills_monitor_handle_ = OomKillsMonitor::StartMonitoring();

Luis Héctor Chávez 2016/07/29 21:48:45 Can this be initialized in the initializer list?

gab 2016/08/01 15:15:02 Done.

}

ArcMetricsService::~ArcMetricsService() {

« no previous file with comments | « components/arc/metrics/arc_metrics_service.h ('k') | components/arc/metrics/oom_kills_monitor.h » ('j') | components/arc/metrics/oom_kills_monitor.h » ('J')